Skip to content

[7.x] [Security Solutions][Detection Engine] Fixes bug with not being able to duplicate indicator matches (#92565)#92717

Merged
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-92565
Feb 25, 2021
Merged

[7.x] [Security Solutions][Detection Engine] Fixes bug with not being able to duplicate indicator matches (#92565)#92717
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-92565

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

@kibanamachine kibanamachine commented Feb 24, 2021

Backports the following commits to 7.x:

@FrankHassanabad @kibanamachine
[Security Solutions][Detection Engine] Fixes bug with not being able …
9cd13bc 
…to duplicate indicator matches (elastic#92565)

## Summary

Fixes an unreleased regression bug where indicator rules could not be be duplicated.
elastic#90356

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Feb 24, 2021
@kibanamachine kibanamachine enabled auto-merge (squash) February 24, 2021 21:35
@kibanamachine kibanamachine mentioned this pull request Feb 24, 2021
Merged
1 task
@kibanamachine
Copy link
Copy Markdown
Contributor Author

kibanamachine commented Feb 25, 2021

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / general / Deletes and recovers more than one rule.Deleting prebuilt rules Deletes and recovers more than one rule

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 60000ms: expected '<button.euiButton.euiButton--primary>' to have text 'Install 2 Elastic prebuilt rules ', but the text was 'Install 1 Elastic prebuilt rule '
    at Context.eval (http://localhost:6121/__cypress/tests?p=cypress/integration/detection_rules/prebuilt_rules.spec.ts:20253:68)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.7MB 7.7MB +80.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @FrankHassanabad

@kibanamachine kibanamachine merged commit 044de1e into elastic:7.x Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@FrankHassanabad FrankHassanabad

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kibanamachine @FrankHassanabad