Skip to content

[7.x] [Security Solution] [Detections] Replace 'partial failure' with 'warning' for rule statuses (#91167)#91598

Merged
dhurley14 merged 1 commit intoelastic:7.xfrom
dhurley14:backport/7.x/pr-91167
Feb 17, 2021
Merged

[7.x] [Security Solution] [Detections] Replace 'partial failure' with 'warning' for rule statuses (#91167)#91598
dhurley14 merged 1 commit intoelastic:7.xfrom
dhurley14:backport/7.x/pr-91167

Conversation

@dhurley14
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

…ing' for rule statuses (elastic#91167)

* removes usage of 'partial failure' status and replaces with a 'warning' status, also adds some logic to be backwards compatible with 'partial failure' statuses

* update integration tests from 'partial failure' to 'warning'

* fix integration test to warn and not error when no index patterns match concrete indices

* fix integration test

* removes outdated comments from the create_rules e2e test
# Conflicts:
#	x-pack/test/detection_engine_api_integration/security_and_spaces/tests/create_rules.ts
@dhurley14 dhurley14 added the backport This PR is a backport of another PR label Feb 17, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.5MB 7.5MB +219.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 237.3KB 237.2KB -10.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dhurley14 dhurley14 merged commit 06580cd into elastic:7.x Feb 17, 2021
@dhurley14 dhurley14 deleted the backport/7.x/pr-91167 branch February 17, 2021 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants