Skip to content

[7.x] Unify Kibana & Elasticsearch logging config keys (#90764)#91548

Merged
mshustov merged 1 commit intoelastic:7.xfrom
mshustov:backport/7.x/pr-90764
Feb 17, 2021
Merged

[7.x] Unify Kibana & Elasticsearch logging config keys (#90764)#91548
mshustov merged 1 commit intoelastic:7.xfrom
mshustov:backport/7.x/pr-90764

Conversation

@mshustov
Copy link
Copy Markdown
Contributor

@mshustov mshustov commented Feb 16, 2021

Backports the following commits to 7.x:

@mshustov @kibanamachine
Unify Kibana & Elasticsearch logging config keys (elastic#90764)
d2e61d6 
* align logging config with ES. rename kind to type.

* rename file "path" to "fileName"

* rename logger "context" to "name"

* update audit log docs and tests

* update docs

* fix integration tests

* update deprecations for audit appender

* add tests for audit logging deprecations

* fix eslint problem

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/security/server/config_deprecations.ts
@mshustov mshustov added the backport This PR is a backport of another PR label Feb 16, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 16, 2021

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / general / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/uptime·ts.uptime overview alert popover controls

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 5 times on tracked branches: https://github.com/elastic/kibana/issues/90555

[00:00:00]       │
[00:01:29]         └-: uptime
[00:01:29]           └-> "before all" hook for "overview page"
[00:01:29]           └-> "before all" hook for "overview page"
[00:01:29]             │ info [uptime/blank] Loading "mappings.json"
[00:01:29]             │ info [uptime/blank] Loading "data.json"
[00:01:29]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613503966961596117] [heartbeat-7-generated-test] creating index, cause [api], templates [], shards [1]/[1]
[00:01:30]             │ info [uptime/blank] Created index "heartbeat-7-generated-test"
[00:01:30]             │ debg [uptime/blank] "heartbeat-7-generated-test" settings undefined
[00:01:31]           └-> overview page
[00:01:31]             └-> "before each" hook: global before each for "overview page"
[00:01:31]             └-> "before each" hook for "overview page"
[00:01:31]               │ debg TestSubjects.exists(uptimeSettingsToOverviewLink)
[00:01:31]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeSettingsToOverviewLink"]') with timeout=0
[00:01:31]               │ debg --- retry.tryForTime error: [data-test-subj="uptimeSettingsToOverviewLink"] is not displayed
[00:01:31]               │ debg navigating to uptime url: http://localhost:61201/app/uptime
[00:01:31]               │ debg navigate to: http://localhost:61201/app/uptime
[00:01:31]               │ debg browser[INFO] http://localhost:61201/app/uptime?_t=1613506301055 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:31]               │
[00:01:31]               │ debg browser[INFO] http://localhost:61201/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:31]               │ debg ... sleep(700) start
[00:01:32]               │ debg ... sleep(700) end
[00:01:32]               │ debg returned from get, calling refresh
[00:01:33]               │ERROR browser[SEVERE] http://localhost:61201/38812/bundles/core/core.entry.js 12:160284 TypeError: Failed to fetch
[00:01:33]               │          at fetch_Fetch.fetchResponse (http://localhost:61201/38812/bundles/core/core.entry.js:6:32451)
[00:01:33]               │          at async interceptResponse (http://localhost:61201/38812/bundles/core/core.entry.js:6:28637)
[00:01:33]               │          at async http://localhost:61201/38812/bundles/core/core.entry.js:6:31117
[00:01:33]               │ debg browser[INFO] http://localhost:61201/app/uptime?_t=1613506301055 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:33]               │
[00:01:33]               │ debg browser[INFO] http://localhost:61201/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:33]               │ debg currentUrl = http://localhost:61201/app/uptime
[00:01:33]               │          appUrl = http://localhost:61201/app/uptime
[00:01:33]               │ debg TestSubjects.find(kibanaChrome)
[00:01:33]               │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:01:33]               │ debg ... sleep(501) start
[00:01:34]               │ERROR browser[SEVERE] http://localhost:61201/38812/bundles/plugin/uptime/uptime.chunk.1.js 2:19527 "API /api/uptime/monitor/list is not returning expected response, Invalid value \"undefined\" supplied to \"summaries.state.summaryPings.tls.server.x509.issuer.distinguished_name\",Invalid value \"undefined\" supplied to \"summaries.state.summaryPings.tls.server.x509.subject.distinguished_name\",Invalid value \"undefined\" supplied to \"summaries.state.summaryPings.tls.server.x509.serial_number\",Invalid value \"undefined\" supplied to \"summaries.state.summaryPings.tls.server.x509.public_key_algorithm\",Invalid value \"undefined\" supplied to \"summaries.state.summaryPings.tls.server.x509.signature_algorithm\",Invalid value \"undefined\" supplied to \"summaries.state.summaryPings.tls.server.x509.not_after\",Invalid value \"undefined\" supplied to \"summaries.state.summaryPings.tls.server.x509.not_before\" for response" Object
[00:01:34]               │ debg ... sleep(501) end
[00:01:34]               │ debg in navigateTo url = http://localhost:61201/app/uptime
[00:01:34]               │ debg TestSubjects.exists(statusPageContainer)
[00:01:34]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:01:36]               │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:01:37]               │ debg isGlobalLoadingIndicatorVisible
[00:01:37]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:01:37]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:01:39]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:01:39]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:01:39]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:01:39]               │ debg TestSubjects.exists(uptimeOverviewPage)
[00:01:39]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeOverviewPage"]') with timeout=2000
[00:01:40]             └- ✓ pass  (550ms) "uptime overview page"
[00:01:40]           └-> overview page with expanded monitor detail
[00:01:40]             └-> "before each" hook: global before each for "overview page with expanded monitor detail"
[00:01:40]             └-> "before each" hook for "overview page with expanded monitor detail"
[00:01:40]               │ debg TestSubjects.exists(uptimeSettingsToOverviewLink)
[00:01:40]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeSettingsToOverviewLink"]') with timeout=0
[00:01:40]               │ debg TestSubjects.click(uptimeSettingsToOverviewLink)
[00:01:40]               │ debg Find.clickByCssSelector('[data-test-subj="uptimeSettingsToOverviewLink"]') with timeout=10000
[00:01:40]               │ debg Find.findByCssSelector('[data-test-subj="uptimeSettingsToOverviewLink"]') with timeout=10000
[00:01:40]               │ debg isGlobalLoadingIndicatorVisible
[00:01:40]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:01:40]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:01:41]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:01:42]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:01:42]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:01:42]               │ debg TestSubjects.exists(uptimeOverviewPage)
[00:01:42]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeOverviewPage"]') with timeout=2000
[00:01:42]             │ debg TestSubjects.click(xpack.uptime.monitorList.a11yTestMonitor.expandMonitorDetail)
[00:01:42]             │ debg Find.clickByCssSelector('[data-test-subj="xpack.uptime.monitorList.a11yTestMonitor.expandMonitorDetail"]') with timeout=10000
[00:01:42]             │ debg Find.findByCssSelector('[data-test-subj="xpack.uptime.monitorList.a11yTestMonitor.expandMonitorDetail"]') with timeout=10000
[00:01:42]             │ debg TestSubjects.click(xpack.uptime.monitorList.actionsPopover.a11yTestMonitor)
[00:01:42]             │ debg Find.clickByCssSelector('[data-test-subj="xpack.uptime.monitorList.actionsPopover.a11yTestMonitor"]') with timeout=10000
[00:01:42]             │ debg Find.findByCssSelector('[data-test-subj="xpack.uptime.monitorList.actionsPopover.a11yTestMonitor"]') with timeout=10000
[00:01:43]             └- ✓ pass  (776ms) "uptime overview page with expanded monitor detail"
[00:01:43]           └-> overview alert popover controls
[00:01:43]             └-> "before each" hook: global before each for "overview alert popover controls"
[00:01:43]             └-> "before each" hook for "overview alert popover controls"
[00:01:43]               │ debg TestSubjects.exists(uptimeSettingsToOverviewLink)
[00:01:43]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeSettingsToOverviewLink"]') with timeout=0
[00:01:43]               │ debg TestSubjects.click(uptimeSettingsToOverviewLink)
[00:01:43]               │ debg Find.clickByCssSelector('[data-test-subj="uptimeSettingsToOverviewLink"]') with timeout=10000
[00:01:43]               │ debg Find.findByCssSelector('[data-test-subj="uptimeSettingsToOverviewLink"]') with timeout=10000
[00:01:43]               │ debg isGlobalLoadingIndicatorVisible
[00:01:43]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:01:43]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:01:44]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:01:45]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:01:45]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:01:45]               │ debg TestSubjects.exists(uptimeOverviewPage)
[00:01:45]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="uptimeOverviewPage"]') with timeout=2000
[00:01:45]             │ debg TestSubjects.click(xpack.uptime.alertsPopover.toggleButton)
[00:01:45]             │ debg Find.clickByCssSelector('[data-test-subj="xpack.uptime.alertsPopover.toggleButton"]') with timeout=10000
[00:01:45]             │ debg Find.findByCssSelector('[data-test-subj="xpack.uptime.alertsPopover.toggleButton"]') with timeout=10000
[00:01:45]             │ info Taking screenshot "/dev/shm/workspace/parallel/20/kibana/x-pack/test/functional/screenshots/failure/uptime overview alert popover controls.png"
[00:01:46]             │ info Current URL is: http://localhost:61201/app/uptime
[00:01:46]             │ info Saving page source to: /dev/shm/workspace/parallel/20/kibana/x-pack/test/functional/failure_debug/html/uptime overview alert popover controls.html
[00:01:46]             └- ✖ fail: uptime overview alert popover controls
[00:01:46]             │      Error: a11y report:
[00:01:46]             │ 
[00:01:46]             │ VIOLATION
[00:01:46]             │   [aria-hidden-focus]: Ensures aria-hidden elements do not contain focusable elements
[00:01:46]             │     Help: https://dequeuniversity.com/rules/axe/4.0/aria-hidden-focus?application=axeAPI
[00:01:46]             │     Elements:
[00:01:46]             │       - #kibana-body
[00:01:46]             │       - div[data-focus-guard="true"][data-aria-hidden="true"][aria-hidden="true"]:nth-child(1)
[00:01:46]             │       - div[data-focus-guard="true"][data-aria-hidden="true"][aria-hidden="true"]:nth-child(2)
[00:01:46]             │       - div[data-focus-guard="true"][data-aria-hidden="true"][aria-hidden="true"]:nth-child(4)
[00:01:46]             │       at Accessibility.testAxeReport (/dev/shm/workspace/parallel/20/kibana/test/accessibility/services/a11y/a11y.ts:76:15)
[00:01:46]             │       at Accessibility.testAppSnapshot (/dev/shm/workspace/parallel/20/kibana/test/accessibility/services/a11y/a11y.ts:49:18)
[00:01:46]             │       at runMicrotasks (<anonymous>)
[00:01:46]             │       at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:01:46]             │       at Context.<anonymous> (test/accessibility/apps/uptime.ts:62:7)
[00:01:46]             │       at Object.apply (/dev/shm/workspace/parallel/20/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
[00:01:46]             │ 
[00:01:46]             │

Stack Trace

Error: a11y report:

VIOLATION
  [aria-hidden-focus]: Ensures aria-hidden elements do not contain focusable elements
    Help: https://dequeuniversity.com/rules/axe/4.0/aria-hidden-focus?application=axeAPI
    Elements:
      - #kibana-body
      - div[data-focus-guard="true"][data-aria-hidden="true"][aria-hidden="true"]:nth-child(1)
      - div[data-focus-guard="true"][data-aria-hidden="true"][aria-hidden="true"]:nth-child(2)
      - div[data-focus-guard="true"][data-aria-hidden="true"][aria-hidden="true"]:nth-child(4)
    at Accessibility.testAxeReport (/dev/shm/workspace/parallel/20/kibana/test/accessibility/services/a11y/a11y.ts:76:15)
    at Accessibility.testAppSnapshot (/dev/shm/workspace/parallel/20/kibana/test/accessibility/services/a11y/a11y.ts:49:18)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at Context.<anonymous> (test/accessibility/apps/uptime.ts:62:7)
    at Object.apply (/dev/shm/workspace/parallel/20/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit 6d7ab50 into elastic:7.x Feb 17, 2021
@mshustov mshustov deleted the backport/7.x/pr-90764 branch February 17, 2021 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mshustov @kibanamachine