Skip to content

[7.x] [Uptime] Feature/80166 add waterfall flyout (#89449)#91233

Merged
dominiqueclarke merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-89449
Feb 12, 2021
Merged

[7.x] [Uptime] Feature/80166 add waterfall flyout (#89449)#91233
dominiqueclarke merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-89449

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* adjust network events

* add metaData to data formatting

* add useFlyout

* adjust waterfall data types

* adjust MiddleTruncatedText to use span instead of div

* add flyout

* adjust sidebar button style

* update tests

* convert content to use sentence case

* pass onBarClick and onProjectionClick as WaterfallChart props

* use undefined value for initial flyoutData state

* add telemetry

* adjust typo in get_network_events

* adjust connection time

* added space between value and units

* adjust flyout spacing, rearrange certificates, and right align values

* adjust flyout labels

* add focus management support to flyout

* improve performance with memoization

* add external link to MiddleTruncatedText

* update data_formatting function

* remove EuiPortal

* add moment mock to data_formatting test

* adjust data_formatting

* adjust network_events runtime types

* remove extra space in test tile

* toggle flyout on sidebar click

* update styling and html for open in new tab resource link

* rename metaData to metadata

* adjust MiddleTruncatedText styling

* adjust WaterfallFlyout heading

* adjust waterfall sidebar item types

* adjust SidebarItem onClick type

* fix license header

* align middle truncated text left

* move flyout logic to a render prop for better composability

* add ip to flyout

* update label for bytes downloaded (compressed)

* lowercase compressed

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label Feb 11, 2021
@dominiqueclarke dominiqueclarke enabled auto-merge (squash) February 11, 2021 22:53
@kibanamachine
Copy link
Copy Markdown
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
uptime 590 593 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
uptime 909.8KB 926.4KB +16.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit 407bcb9 into elastic:7.x Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants