[7.x] [Workplace Search] Update personal dashboard (#91136)#91219
Merged
scottybollinger merged 1 commit intoelastic:7.xfrom Feb 11, 2021
Merged
[7.x] [Workplace Search] Update personal dashboard (#91136)#91219scottybollinger merged 1 commit intoelastic:7.xfrom
scottybollinger merged 1 commit intoelastic:7.xfrom
Conversation
* Remove "Add a private content source" sidebar link * Update groupsSentence to cover different number of groups Different cases: 1 group: You have access to the following sources through the group Default. 2 groups: You have access to the following sources through the groups Default and Engineering. (no comma before 'and') 3+ groups: You have access to the following sources through the groups Default, Marketing, and Engineering. (comma before 'and') * Create PrivateSourcesLayout as a copy of Layout In this commit PrivateSourcesLayout is a full copy of Layout. It's going to be updated in later commits. * Remove unused code from PrivateSourcesLayout * Update read-only mode warning copy for end-users * Move copy to constants file * Add width styles to new sidebar Also moved private_sources_layout styles to sources.scss file. Having separate files for that little amount of custom styles is unnecessary. * Move top-level header to sidebar * Add missing padding to sidebar * Replace ViewContentHeader with ContentSection props * Move variables over the components * Remove unused classnames * DRY out privateSourcesTable and privateSourcesEmptyState by extracting privateSourcesSection that contains common markup. * DRY out sharedSourcesTable and sharedSourcesEmptyState by extracting sharedSourcesSection that contains common markup. * Reorder code blocks inside the file To match the order the components appear in UI * Add newline to the groups enumeration sentence So it looks good with any number of groups * Update x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/private_sources_layout.tsx Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co> Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
Author
💚 Build SucceededMetrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: