Skip to content

[7.x] Implement custom global header banner (#87438)#91089

Merged
pgayvallet merged 1 commit intoelastic:7.xfrom
pgayvallet:backport/7.x/pr-87438
Feb 11, 2021
Merged

[7.x] Implement custom global header banner (#87438)#91089
pgayvallet merged 1 commit intoelastic:7.xfrom
pgayvallet:backport/7.x/pr-87438

Conversation

@pgayvallet
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* first draft

* update plugin list

* fix tsproject

* update bundle limits file

* remove unused start dep

* adapt imports

* POC of footer banner

* update styles, mostly

* plug banner to uiSettings

* adding some unit tests

* add tests on sort_fields

* cleanup sums in sass mixins

* some self review stuff

* update generated doc

* add tests for color field

* update chrome header test snapshots

* retrieve license info from the server

* switch from uiSettings to plugin config

* update plugin list description

* update default colors

* NIT

* add markdown support

* fix banner overlap in fullscreen mode

* change banner height to 32px

* change banner's font size to 14

* delete unused uiSettings
@pgayvallet pgayvallet added the backport This PR is a backport of another PR label Feb 11, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
advancedSettings 56 57 +1
banners - 18 +18
core 444 446 +2
total +21

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
advancedSettings 919.5KB 920.1KB +625.0B
discover 420.8KB 424.7KB +3.9KB
home 182.5KB 184.6KB +2.1KB
security 724.4KB 724.9KB +560.0B
spaces 41.2KB 41.5KB +268.0B
total +7.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
banners - 13.6KB +13.6KB
core 468.0KB 475.7KB +7.7KB
kibanaOverview 45.0KB 46.9KB +1.8KB
maps 139.0KB 140.5KB +1.5KB
painlessLab 22.2KB 24.0KB +1.8KB
searchprofiler 45.7KB 47.4KB +1.7KB
total +28.1KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 80bfebf into elastic:7.x Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants