Skip to content

[7.x] [Lens] Retain column config (#90048)#90598

Merged
flash1293 merged 1 commit intoelastic:7.xfrom
flash1293:backport/7.x/pr-90048
Feb 8, 2021
Merged

[7.x] [Lens] Retain column config (#90048)#90598
flash1293 merged 1 commit intoelastic:7.xfrom
flash1293:backport/7.x/pr-90048

Conversation

@flash1293
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

@flash1293 flash1293 added the backport This PR is a backport of another PR label Feb 8, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/search/session·ts.apis search search session should sync search ids into not persisted session

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/90332

[00:00:00]       │
[00:00:00]         └-: apis
[00:00:00]           └-> "before all" hook in "apis"
[00:00:00]           └-: search
[00:00:00]             └-> "before all" hook in "search"
[00:00:05]             └-: search session
[00:00:05]               └-> "before all" hook for "should fail to extend a nonexistent session"
[00:00:05]               └-> should fail to extend a nonexistent session
[00:00:05]                 └-> "before each" hook: global before each for "should fail to extend a nonexistent session"
[00:00:05]                 │ proc [kibana]   log   [13:39:05.318] [error][dataEnhanced][data_enhanced][plugins] {
[00:00:05]                 │ proc [kibana]   statusCode: 404,
[00:00:05]                 │ proc [kibana]   error: 'Not Found',
[00:00:05]                 │ proc [kibana]   message: 'Saved object [search-session/123] not found'
[00:00:05]                 │ proc [kibana] }
[00:00:05]                 └- ✓ pass  (47ms) "apis search search session should fail to extend a nonexistent session"
[00:00:05]               └-> should sync search ids into not persisted session
[00:00:05]                 └-> "before each" hook: global before each for "should sync search ids into not persisted session"
[00:00:05]                 └- ✖ fail: apis search search session should sync search ids into not persisted session
[00:00:05]                 │      Error: expected [ 'FnIyZWFZQTNNUlJHcnNBTHdMejZWQ1EbY0stMDN5TlpSOHVhT2lFZXZIMG1hdzoxNzg4' ] to contain 'Fmdja1ZnbERfUTRtLTE0RUlzT3FIWFEbY0stMDN5TlpSOHVhT2lFZXZIMG1hdzoxODI2'
[00:00:05]                 │       at Assertion.assert (/dev/shm/workspace/parallel/8/kibana/packages/kbn-expect/expect.js:100:11)
[00:00:05]                 │       at Assertion.contain (/dev/shm/workspace/parallel/8/kibana/packages/kbn-expect/expect.js:447:10)
[00:00:05]                 │       at Context.<anonymous> (test/api_integration/apis/search/session.ts:262:29)
[00:00:05]                 │       at Object.apply (/dev/shm/workspace/parallel/8/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
[00:00:05]                 │ 
[00:00:05]                 │ 

Stack Trace

Error: expected [ 'FnIyZWFZQTNNUlJHcnNBTHdMejZWQ1EbY0stMDN5TlpSOHVhT2lFZXZIMG1hdzoxNzg4' ] to contain 'Fmdja1ZnbERfUTRtLTE0RUlzT3FIWFEbY0stMDN5TlpSOHVhT2lFZXZIMG1hdzoxODI2'
    at Assertion.assert (/dev/shm/workspace/parallel/8/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.contain (/dev/shm/workspace/parallel/8/kibana/packages/kbn-expect/expect.js:447:10)
    at Context.<anonymous> (test/api_integration/apis/search/session.ts:262:29)
    at Object.apply (/dev/shm/workspace/parallel/8/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 892.0KB 892.1KB +164.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 5dd2323 into elastic:7.x Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants