Skip to content

[7.x] [Data Table] Add unit tests (#90173)#90596

Merged
sulemanof merged 1 commit intoelastic:7.xfrom
sulemanof:backport/7.x/pr-90173
Feb 8, 2021
Merged

[7.x] [Data Table] Add unit tests (#90173)#90596
sulemanof merged 1 commit intoelastic:7.xfrom
sulemanof:backport/7.x/pr-90173

Conversation

@sulemanof
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* Move formatting columns into response handler

* Use shared csv export

* Cleanup files

* Fix type

* Fix translation

* Filter out non-dimension values

* Add unit tests for tableVisResponseHandler

* Add unit tests for createFormattedTable

* Add unit tests for addPercentageColumn

* Add unit tests for usePagination

* Add unit tests for useUiState

* Add unit tests for table visualization

* Add unit tests for TableVisBasic

* Add unit tests for cell

* Update license

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@sulemanof sulemanof added the backport This PR is a backport of another PR label Feb 8, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTable 120.8KB 120.8KB -89.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof merged commit f4a456d into elastic:7.x Feb 8, 2021
@sulemanof sulemanof deleted the backport/7.x/pr-90173 branch February 8, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants