[Telemetry] Add stakeholders to schema changes#90143
Conversation
.github/CODEOWNERS
Outdated
| src/plugins/telemetry/schema/oss_plugins.json @elastic/kibana-core | ||
| x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json @elastic/kibana-core | ||
| src/plugins/telemetry/schema/ @elastic/kibana-core @thesmallestduck @elastic/infra-telemetry | ||
| x-pack/plugins/telemetry_collection_xpack/schema/ @elastic/kibana-core @thesmallestduck @elastic/infra-telemetry |
There was a problem hiding this comment.
Q: Should we replace the @thesmallestduck mention to a team instead? Maybe we want to repurpose @elastic/kibana-telemetry?
There was a problem hiding this comment.
I'm generally +1 to using teams over individuals, to make maintenance easier. Not sure what the right team would be, though 🤔
Would it make sense to add @thesmallestduck to kibana-core, perhaps? Or maybe a kibana-core-pm group, if there is one?
Bamieh
left a comment
There was a problem hiding this comment.
I think we only need @elastic/kibana-core as the gatekeepers of the schema.
We can ping other individuals/teams as required per change. I'm sure everyone would appreciate having less notifications if they are not concerned with the changes most of the time.
|
@Bamieh this came up from a discussion with the Infra team. They'd prefer to be notified as soon as the changes are about to happen vs. waiting for FF. IMO, this means we'll need to always ping the Infra team about every I also think that their input can be very valuable, as they can ask for different input formats (if needed) right before the collector is merged. In addition, the reason for including IMO, |
|
@elasticmachine merge upstream |
Summary
As we agreed in our last sync, we're adding the Telemetry stakeholders as code owners to the schema changes. This way they'll be notified (and can ACK, and kick-off discussions about any changes to new data or deleted fields)
Checklist
Delete any items that are not applicable to this PR.
For maintainers