Skip to content

[7.x] [Security Solution] [Detections] Remove allow_no_indices to prevent error being thrown in response of field capabilities (#89927)#90072

Merged
dhurley14 merged 1 commit intoelastic:7.xfrom
dhurley14:backport/7.x/pr-89927
Feb 2, 2021
Merged

Conversation

@dhurley14
Copy link
Copy Markdown
Contributor

@dhurley14 dhurley14 commented Feb 2, 2021

Backports the following commits to 7.x:

@dhurley14
[Security Solution] [Detections] Remove allow_no_indices to prevent e…
7f3a5f0 
…rror being thrown in response of field capabilities (elastic#89927)

* remove allow_no_indices param, adds a check if response has empty indices property then write error status with index patterns provided to rule

* fix tests

* fix tests and update with comments

* update integration tests

* adds integration test for when an index pattern doesn't exist the rule should fail and when one index pattern does exist but another does not, the rule should succeed
@dhurley14 dhurley14 added the backport This PR is a backport of another PR label Feb 2, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 2, 2021

💛 Build succeeded, but was flaky

Test Failures

We show one primary callout.Detections > Callouts indicating read-only access to resources On Detections home page We show one primary callout

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 10000ms: Expected to find element: `[data-test-subj="callout-read-only-access-to-alerts"]`, but never found it.
    at Object.waitForCallOutToBeShown (http://localhost:6111/__cypress/tests?p=cypress/integration/detection_alerts/alerts_detection_callouts_readonly.spec.ts:21456:10)
    at Context.eval (http://localhost:6111/__cypress/tests?p=cypress/integration/detection_alerts/alerts_detection_callouts_readonly.spec.ts:20241:24)
We hide it and persist the dismissal.Detections > Callouts indicating read-only access to resources On Detections home page When a user clicks Dismiss on the callout We hide it and persist the dismissal

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 10000ms: Expected to find element: `[data-test-subj="callout-read-only-access-to-alerts"]`, but never found it.
    at Object.waitForCallOutToBeShown (http://localhost:6111/__cypress/tests?p=cypress/integration/detection_alerts/alerts_detection_callouts_readonly.spec.ts:21456:10)
    at Context.eval (http://localhost:6111/__cypress/tests?p=cypress/integration/detection_alerts/alerts_detection_callouts_readonly.spec.ts:20245:28)
We hide it and persist the dismissal.Detections > Callouts indicating read-only access to resources On Rules Management page When a user clicks Dismiss on the callout We hide it and persist the dismissal

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 10000ms: Expected to find element: `[data-test-subj="callout-read-only-access-to-rules"]`, but never found it.
    at Object.waitForCallOutToBeShown (http://localhost:6111/__cypress/tests?p=cypress/integration/detection_alerts/alerts_detection_callouts_readonly.spec.ts:21456:10)
    at Context.eval (http://localhost:6111/__cypress/tests?p=cypress/integration/detection_alerts/alerts_detection_callouts_readonly.spec.ts:20261:28)

and 2 more failures, only showing the first 3.

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dhurley14 dhurley14 merged commit 3520dce into elastic:7.x Feb 2, 2021
@dhurley14 dhurley14 deleted the backport/7.x/pr-89927 branch February 2, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhurley14 @kibanamachine