[7.x] [ILM] New copy for rollover and small refactor for timeline (#89422)#89840
Merged
jloleysens merged 1 commit intoelastic:7.xfrom Feb 1, 2021
Merged
[7.x] [ILM] New copy for rollover and small refactor for timeline (#89422)#89840jloleysens merged 1 commit intoelastic:7.xfrom
jloleysens merged 1 commit intoelastic:7.xfrom
Conversation
…89422) * refactor timeline and relative ms calculation logic for easier use outside of edit_policy section * further refactor, move child component to own file in timeline, and clean up public API for relative timing calculation * added copy to call out variation in timing (slop) introduced by rollover * use separate copy for timeline * remove unused import * fix unresolved merge * implement copy feedback * added component integration for showing/hiding hot phase icon on timeline Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack Security Functional Tests (OpenID Connect).x-pack/test/security_functional/tests/oidc/url_capture·ts.security app - OIDC interactions URL capture can login preserving original URLStandard OutStack TraceChrome X-Pack Security Functional Tests (OpenID Connect).x-pack/test/security_functional/tests/oidc/url_capture·ts.security app - OIDC interactions URL capture "after each" hook for "can login preserving original URL"Standard OutStack TraceMetrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: