Skip to content

[7.x] [Core] Explicit typings for request handler context (#88718)#88975

Merged
mshustov merged 1 commit intoelastic:7.xfrom
mshustov:backport/7.x/pr-88718
Jan 21, 2021
Merged

[7.x] [Core] Explicit typings for request handler context (#88718)#88975
mshustov merged 1 commit intoelastic:7.xfrom
mshustov:backport/7.x/pr-88718

Conversation

@mshustov
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* move context to server part. couple with RequestHandlerContext

Context implementation will be simplified in follow-up.

* adopt core code

* adopt bfetch code

* adopt data code

* adopt search examples

* adopt vis_type_timelion

* adopt vis_type_timeseries

* adopt plugin functional tests

* adopt actions

* adopt alerting plugin

* adopt APM plugin

* adopt beats_management

* adopt case plugin

* adopt cross_cluster_replication

* adopt data_enhanced

* adopt event_log

* adopt global_search

* adopt index_management

* adopt infra

* adopt licensing

* adopt lists

* adopt logstash

* adopt reporting

* adopt observability

* adopt monitoring

* adopt rollup

* adopt so tagging

* adopt security

* adopt security_solutions

* adopt watcher

* adopt uptime

* adopt spaces

* adopt snapshot_restore

* adopt features changes

* mute error when null used to extend context

* update docs

* small cleanup

* add type safety for return type

* refactor registerRouteHandlerContext type

* update docs

* update license header

* update docs

* fix type error. fetch body does not accept array of strings

* fix telemetry test

* remove unnecessary ts-ignore

* address comments

* update docs
# Conflicts:
#	docs/development/plugins/data/server/kibana-plugin-plugins-data-server.plugin.start.md
#	src/plugins/data/server/server.api.md
#	x-pack/plugins/monitoring/server/plugin.ts
@mshustov mshustov added the backport This PR is a backport of another PR label Jan 21, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky


Test Failures

Creates a timeline.Timelines Creates a timeline

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 19 times on tracked branches: https://github.com/elastic/kibana/issues/79389

AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="description"]`, but never found it.
    at Context.eval (http://localhost:6111/__cypress/tests?p=cypress/integration/timelines/creation.spec.ts:15055:16)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
core 447 446 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 564.3KB 558.9KB -5.4KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit 99cd66f into elastic:7.x Jan 21, 2021
@mshustov mshustov deleted the backport/7.x/pr-88718 branch January 21, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants