Skip to content

[7.11] [Security Solution] Fix sorting on unmapped fields in Timeline Events… (#87241)#87965

Merged
patrykkopycinski merged 1 commit intoelastic:7.11from
XavierM:backport/7.11/pr-87241
Jan 12, 2021
Merged

[7.11] [Security Solution] Fix sorting on unmapped fields in Timeline Events… (#87241)#87965
patrykkopycinski merged 1 commit intoelastic:7.11from
XavierM:backport/7.11/pr-87241

Conversation

@XavierM
Copy link
Copy Markdown
Contributor

@XavierM XavierM commented Jan 12, 2021

Backports the following commits to 7.11:

elastic#87241)

* [Security Solution] Fix sorting on unmapped fields in Timeline Events table

* set unmapped_type to the column type

* add missing types

* Update saved_object_mappings.ts

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
@XavierM XavierM added the backport This PR is a backport of another PR label Jan 12, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky


Test Failures

Creates a timeline.Timelines Creates a timeline

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 19 times on tracked branches: https://github.com/elastic/kibana/issues/79389

AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="description"]`, but never found it.
    at Context.eval (http://localhost:6111/__cypress/tests?p=cypress/integration/timeline_creation.spec.ts:15055:16)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB +768.0B
triggersActionsUi 1.5MB 1.5MB -26.9KB
total -26.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 162.0KB 162.1KB +102.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
siem-ui-timeline 90 91 +1
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 3e08bea into elastic:7.11 Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants