Skip to content

[7.11] [SecuritySolution][Detections] Fix "Closing a signal silently fails with reduced privileges" (#86908)#87414

Merged
yctercero merged 1 commit intoelastic:7.11from
yctercero:backport/7.11/pr-86908
Jan 6, 2021
Merged

[7.11] [SecuritySolution][Detections] Fix "Closing a signal silently fails with reduced privileges" (#86908)#87414
yctercero merged 1 commit intoelastic:7.11from
yctercero:backport/7.11/pr-86908

Conversation

@yctercero
Copy link
Copy Markdown
Contributor

@yctercero yctercero commented Jan 6, 2021

Backports the following commits to 7.11:

@banderror @yctercero
[SecuritySolution][Detections] Fix "Closing a signal silently fails w…
5f8331d 
…ith reduced privileges" (elastic#86908)

## Summary

This PR introduces the following changes. If the user has insufficient write privileges on the signals index:

- we disable the status-changing actions on detection alerts ("Open alert", "Close Alert", "Mark in progress") in the context menu of an alert in alerts table
- we make sure to show the corresponding callout that tells about read-only access to detection alerts
- in the callout we provide links to docs for understanding why/how to fix
@yctercero yctercero added the backport This PR is a backport of another PR label Jan 6, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 6, 2021

💛 Build succeeded, but was flaky

Test Failures

"before all" hook for "sets the KQL from a single IP with a value for the query".ml conditional links "before all" hook for "sets the KQL from a single IP with a value for the query"

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 4 times on tracked branches: https://github.com/elastic/kibana/issues/86979

Error: Timed out while retrying, last result was: {false}

Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `ml conditional links`

Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
    at Context.completeOrRetry (http://localhost:61131/__cypress/tests?p=cypress/support/index.js:1414:13)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2166 2171 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB +4.4KB
triggersActionsUi 1.5MB 1.5MB -26.9KB
total -22.5KB

Distributable file count

id before after diff
default 47634 48397 +763

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 162.0KB 162.1KB +102.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero merged commit a8e6979 into elastic:7.11 Jan 6, 2021
@banderror banderror mentioned this pull request Jan 6, 2021
Closed
@yctercero yctercero deleted the backport/7.11/pr-86908 branch October 13, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yctercero @kibanamachine @banderror