Skip to content

[7.x] [Alerting UI] Alert and Connector flyouts Save and Save&Test buttons should be active by default. (#86708)#87380

Merged
YulNaumenko merged 1 commit intoelastic:7.xfrom
YulNaumenko:backport/7.x/pr-86708
Jan 5, 2021
Merged

[7.x] [Alerting UI] Alert and Connector flyouts Save and Save&Test buttons should be active by default. (#86708)#87380
YulNaumenko merged 1 commit intoelastic:7.xfrom
YulNaumenko:backport/7.x/pr-86708

Conversation

@YulNaumenko
Copy link
Copy Markdown
Contributor

@YulNaumenko YulNaumenko commented Jan 5, 2021

Backports the following commits to 7.x:

@YulNaumenko
[Alerting UI] Alert and Connector flyouts Save and Save&Test buttons …
e0af132 
…should be active by default. (elastic#86708)

* Alert and Connector flyouts Save and Save&Test buttons should be active by default.

* fixed typechecks

* fixed typechecks

* refactored repeted code

* fixed typechecks

* fixed typechecks

* fixed typechecks

* fixed due to comments

* fixed failing tests

* fixed due to comments

* fixed due to comments

* fixed due to comments

* fixed typescript checks
@YulNaumenko YulNaumenko added the backport This PR is a backport of another PR label Jan 5, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 5, 2021

💛 Build succeeded, but was flaky

Test Failures

"before all" hook for "removes the message field from the timeline when the user un-checks the field".Fields Browser Editing the timeline "before all" hook for "removes the message field from the timeline when the user un-checks the field"

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 25 times on tracked branches: https://github.com/elastic/kibana/issues/65497

Error: Timed out while retrying, last result was: {false}

Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `Editing the timeline`

Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
    at Context.completeOrRetry (http://localhost:6111/__cypress/tests?p=cypress/support/index.js:1414:13)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackAlerts 114.4KB 114.4KB +4.0B
triggersActionsUi 1.6MB 1.5MB -21.6KB
total -21.6KB

Distributable file count

id before after diff
default 47592 48355 +763

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 246.7KB 246.7KB +29.0B
triggersActionsUi 162.5KB 165.3KB +2.8KB
total +2.8KB
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko YulNaumenko merged commit fbc0d59 into elastic:7.x Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@YulNaumenko @kibanamachine