[Workplace Search] Move Personal Dashboard link to header#87244
Merged
scottybollinger merged 7 commits intoelastic:masterfrom Jan 5, 2021
Merged
[Workplace Search] Move Personal Dashboard link to header#87244scottybollinger merged 7 commits intoelastic:masterfrom
scottybollinger merged 7 commits intoelastic:masterfrom
Conversation
We aren’t going to use icons like we have in ent-search
The external href to sources will be changed once that component is built
CI was failing and this should fix it
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the link for the personal dashboard to the header, as per the new design. Like other links, it uses the legacy external href since we have not created the personal dashboard yet.
NOTE: Best to use Hide whitespace changes option when reviewing
Before
After
Checklist