Pinging @elastic/kibana-gis (Team:Geo)

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

I'd add #CC# tags too, so we get code coverage stats on them

I'd add #CC# tags too, so we get code coverage stats on them

@thomasneirynck Happy to, just want to check one detail. I actually left #CC# out since it's already done one level higher for the entire plugin here, albeit by the alerting team:

wrt #87188 (comment)

good point. I don't know. Basically, we'd want these directories to to be tracked under the gis-team as well, so code-coverage stats for the gis-team capture include these dirs. cc @LeeDr do you know if this would cause problems for stats-reporting?

I think the comments on the CODEOWNERS file could be a little more clear. They currently say;

# GitHub CODEOWNERS definition
# Identify which groups will be pinged by changes to different parts of the codebase.
# For more info, see https://help.github.com/articles/about-codeowners/

# The #CC# prefix delineates Code Coverage,
# used for the 'team' designator within Kibana Stats

I'd like @wayneseymour to confirm but I think this is true;

• the lines which don't start with #CC# are used for code coverage AND trigger code reviews
• the lines which do start with #CC# are only used for code coverage

Multiple teams can be listed both with and without the #CC# and all are combined for code coverage (the paths will be included when filtering by any of those teams).

Or do I have this wrong and the #CC# overrides the non-#CC# lines so that we could assign a single code coverage team even if multiple teams are triggered for code reviews?

• the lines which don't start with #CC# are used for code coverage AND trigger code reviews
• the lines which do start with #CC# are only used for code coverage

Correct!

Sounds like we're in good shape then. Thanks all!

For future use: https://github.com/elastic/kibana/blob/master/src/dev/code_coverage/docs/team_assignment/README.md#team-assignment-parsing-from-githubcodeowners @aaronjcaldwell @LeeDr