Skip to content

[7.x] [Visualizations] Remove vis_default_editor - visualize plugins cyclic dependencies (#85422)#86753

Merged
alexwizp merged 1 commit intoelastic:7.xfrom
alexwizp:backport/7.x/pr-85422
Dec 22, 2020
Merged

[7.x] [Visualizations] Remove vis_default_editor - visualize plugins cyclic dependencies (#85422)#86753
alexwizp merged 1 commit intoelastic:7.xfrom
alexwizp:backport/7.x/pr-85422

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

… dependencies (elastic#85422)

* [Visualizations] Remove vis_default_editor - visualize plugins cyclic dependencies

# Conflicts:
#	src/plugins/visualize/kibana.json

* fix CI

* fix CI

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@alexwizp alexwizp added the backport This PR is a backport of another PR label Dec 22, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visDefaultEditor 125 126 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -26.9KB
visDefaultEditor 301.0KB 301.0KB +1.0B
visualize 131.3KB 131.2KB -52.0B
total -26.9KB

Distributable file count

id before after diff
default 47486 48249 +763

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 162.5KB 162.6KB +102.0B
visDefaultEditor 46.0KB 46.5KB +491.0B
visualize 40.4KB 42.3KB +1.9KB
total +2.5KB
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit a74c4cc into elastic:7.x Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants