Skip to content

[7.x] [Visualizations] Remove charts - editor plugins cyclic dependencies (#84887)#86730

Merged
stratoula merged 1 commit intoelastic:7.xfrom
stratoula:backport/7.x/pr-84887
Dec 22, 2020
Merged

[7.x] [Visualizations] Remove charts - editor plugins cyclic dependencies (#84887)#86730
stratoula merged 1 commit intoelastic:7.xfrom
stratoula:backport/7.x/pr-84887

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

…lastic#84887)

* Remove charts - editor cyclic dependencies

* Move translations from the charts plugin to the editor plugin

* Remove the dependency from the script as it is gone

* Fix types

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@stratoula stratoula added the backport This PR is a backport of another PR label Dec 22, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
charts 76 67 -9
visDefaultEditor 115 125 +10
total +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -26.9KB
visTypeMarkdown 12.9KB 12.9KB +58.0B
visTypeMetric 20.8KB 20.8KB +1.0B
visTypeTable 154.1KB 154.1KB +80.0B
visTypeTagcloud 284.7KB 284.7KB -1.0B
visTypeVislib 643.7KB 643.9KB +145.0B
visTypeXy 137.6KB 137.6KB +1.0B
total -26.6KB

Distributable file count

id before after diff
default 47486 48249 +763

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
charts 178.7KB 163.8KB -15.0KB
mapsLegacy 94.3KB 94.3KB +10.0B
regionMap 44.3KB 44.4KB +60.0B
tileMap 44.5KB 44.5KB +50.0B
triggersActionsUi 162.6KB 162.7KB +102.0B
visDefaultEditor 30.9KB 46.0KB +15.1KB
visTypeMarkdown 14.6KB 14.4KB -233.0B
visTypeMetric 26.3KB 26.4KB +85.0B
visTypeTable 11.7KB 11.5KB -233.0B
visTypeTagcloud 19.2KB 19.0KB -297.0B
total -287.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit c1fe466 into elastic:7.x Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants