Skip to content

[7.x] [Data table] Reactify & EUIficate the visualization (#70801)#85936

Merged
sulemanof merged 2 commits intoelastic:7.xfrom
sulemanof:backport/7.x/pr-70801
Dec 16, 2020
Merged

[7.x] [Data table] Reactify & EUIficate the visualization (#70801)#85936
sulemanof merged 2 commits intoelastic:7.xfrom
sulemanof:backport/7.x/pr-70801

Conversation

@sulemanof
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* Use data grid for table vis

* Create basic table template

* Add table_vis_split component

* Apply cell filtering

* Add aria-label attributes

* Use field formatters for values

* Add no results component

* Remove legacy dependencies

* Add usePagination

* Create usePagination util

* Use percentage column and total row

* Use csv export button

* Update labels

* Fix merge conflicts

* Use split table

* Fix functional tests

* Fix dashboard tests

* Update data table functional tests

* Fix missed test

* Introduce showToolbar option

* Remove useless package

* Fix merge conflicts

* Return back kibanaUtils required bundle

* Revert "Remove useless package"

This reverts commit 144a7cd.

* Use feature flag for legacy vis

* Add footer row

* Remove lock files

* Revert "Remove lock files"

This reverts commit 5c5acd7.

* Minor fixes

* Use common no result message

* Fix broken tests

* Use ui state sorting

* Fix error

* Fix merge conflicts

* Add legacy functional tests

* Pull pagination footer up to keep with table

and fix column split growing continuously in dashboard

* Comments fixes

* Use cell actions for filtering

* Fix translations

* Fix comments

* Reduce legacy tests amount

* Update sorting

* Update split column layout

* Add telemetry for legacy vis

* Apply latest changes for split table

* Fix eslint errors

* Use aria labels with values

* Use aria label for export btn

* Fix functional test

* Update translations

* Cleanup

* Truncate cells content

* Enhance types in table_vis_response_handler.ts

* Persist columns width on change

* Fix sorting history

* Add a migration script for toolbar

* Export sorted table

* Use reportUiCounter instead of reportUiStats

* Fix integration tests

* Fix typos

* Adjust FieldFormat type

* Hide the density selector

* Update docs

* Fix pagination

* Restrict hiding the toolbar

* Fix column index on filter

* Add closePopover action

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	scripts/functional_tests.js
@sulemanof sulemanof added the backport This PR is a backport of another PR label Dec 15, 2020
@sulemanof
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
visTypeTable 44 84 +40

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.5MB 1.5MB -26.9KB
visTypeTable 66.8KB 153.8KB +87.0KB
total +60.2KB

Distributable file count

id before after diff
default 47543 48316 +773
oss 27811 27821 +10

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 1003.5KB 1003.6KB +71.0B
triggersActionsUi 161.5KB 161.6KB +102.0B
visTypeTable 19.1KB 11.7KB -7.4KB
total -7.2KB
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1
visTypeTable 2 5 +3
total +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof merged commit 9816da3 into elastic:7.x Dec 16, 2020
@sulemanof sulemanof deleted the backport/7.x/pr-70801 branch December 16, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants