[Visualizations] Remove src/plugins/charts -> src/plugins/expressions cyclic dependencies by alexwizp · Pull Request #85788 · elastic/kibana

alexwizp · 2020-12-14T14:56:30Z

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

… cyclic dependencies

alexwizp · 2020-12-15T10:58:52Z

@elasticmachine merge upstream

kibanamachine · 2020-12-15T11:14:02Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 732e460
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

API Integration Tests.test/api_integration/apis/saved_objects/find·js.apis saved_objects find without kibana index page beyond total should return 200 with empty response

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/85911

[00:00:00]       │
[00:00:00]         └-: apis
[00:00:00]           └-> "before all" hook
[00:01:47]           └-: saved_objects
[00:01:47]             └-> "before all" hook
[00:02:26]             └-: find
[00:02:26]               └-> "before all" hook
[00:02:29]               └-: without kibana index
[00:02:29]                 └-> "before all" hook
[00:02:29]                 └-> "before all" hook
[00:02:29]                 └-> should return 200 with empty response
[00:02:29]                   └-> "before each" hook: global before each
[00:02:29]                   └- ✓ pass  (8ms) "apis saved_objects find without kibana index should return 200 with empty response"
[00:02:29]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1608029977556521322] [.kibana] creating index, cause [auto(update api)], templates [], shards [1]/[1]
[00:02:29]                 └-: unknown type
[00:02:29]                   └-> "before all" hook
[00:02:29]                 └-: page beyond total
[00:02:29]                   └-> "before all" hook
[00:02:29]                   └-> should return 200 with empty response
[00:02:29]                     └-> "before each" hook: global before each
[00:02:29]                     │ info [r.suppressed] [kibana-ci-immutable-ubuntu-16-tests-xxl-1608029977556521322] path: /.kibana/_search, params: {rest_total_hits_as_int=true, size=100, index=.kibana, from=9900}
[00:02:29]                     │      org.elasticsearch.action.search.SearchPhaseExecutionException: all shards failed
[00:02:29]                     │      	at org.elasticsearch.action.search.AbstractSearchAsyncAction.onPhaseFailure(AbstractSearchAsyncAction.java:607) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.action.search.AbstractSearchAsyncAction.executeNextPhase(AbstractSearchAsyncAction.java:342) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.action.search.AbstractSearchAsyncAction.onPhaseDone(AbstractSearchAsyncAction.java:642) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.action.search.AbstractSearchAsyncAction.onShardFailure(AbstractSearchAsyncAction.java:425) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.action.search.AbstractSearchAsyncAction$1.onFailure(AbstractSearchAsyncAction.java:273) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.action.search.SearchExecutionStatsCollector.onFailure(SearchExecutionStatsCollector.java:73) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.action.ActionListenerResponseHandler.handleException(ActionListenerResponseHandler.java:59) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.action.search.SearchTransportService$ConnectionCountingHandler.handleException(SearchTransportService.java:415) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.transport.TransportService$6.handleException(TransportService.java:620) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.transport.TransportService$ContextRestoreResponseHandler.handleException(TransportService.java:1164) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.transport.TransportService$DirectResponseChannel.processException(TransportService.java:1273) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.transport.TransportService$DirectResponseChannel.sendResponse(TransportService.java:1247) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.transport.TaskTransportChannel.sendResponse(TaskTransportChannel.java:61) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.transport.TransportChannel.sendErrorResponse(TransportChannel.java:56) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.action.support.ChannelActionListener.onFailure(ChannelActionListener.java:51) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.action.ActionRunnable.onFailure(ActionRunnable.java:88) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.onFailure(ThreadContext.java:721) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:39) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130) [?:?]
[00:02:29]                     │      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630) [?:?]
[00:02:29]                     │      	at java.lang.Thread.run(Thread.java:832) [?:?]
[00:02:29]                     │      Caused by: org.elasticsearch.action.NoShardAvailableActionException: [kibana-ci-immutable-ubuntu-16-tests-xxl-1608029977556521322][127.0.0.1:6153][indices:data/read/search[phase/query]]
[00:02:29]                     │      	at org.elasticsearch.action.search.AbstractSearchAsyncAction.onShardFailure(AbstractSearchAsyncAction.java:458) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	at org.elasticsearch.action.search.AbstractSearchAsyncAction.onShardFailure(AbstractSearchAsyncAction.java:407) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:02:29]                     │      	... 17 more
[00:02:29]                     │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xxl-1608029977556521322] [.kibana/dbHrWiCUR4SbhtxaqJPHag] create_mapping
[00:02:29]                     └- ✖ fail: apis saved_objects find without kibana index page beyond total should return 200 with empty response
[00:02:29]                     │      Error: expected 200 "OK", got 503 "Service Unavailable"
[00:02:29]                     │       at Test._assertStatus (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:268:12)
[00:02:29]                     │       at Test._assertFunction (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:283:11)
[00:02:29]                     │       at Test.assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:173:18)
[00:02:29]                     │       at assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:131:12)
[00:02:29]                     │       at /dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:128:5
[00:02:29]                     │       at Test.Request.callback (/dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:718:3)
[00:02:29]                     │       at /dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:906:18
[00:02:29]                     │       at IncomingMessage.<anonymous> (/dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/parsers/json.js:19:7)
[00:02:29]                     │       at endReadableNT (_stream_readable.js:1327:12)
[00:02:29]                     │       at processTicksAndRejections (internal/process/task_queues.js:80:21)
[00:02:29]                     │ 
[00:02:29]                     │

Stack Trace

Error: expected 200 "OK", got 503 "Service Unavailable"
    at Test._assertStatus (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:268:12)
    at Test._assertFunction (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:283:11)
    at Test.assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:173:18)
    at assert (/dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:131:12)
    at /dev/shm/workspace/kibana/node_modules/supertest/lib/test.js:128:5
    at Test.Request.callback (/dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:718:3)
    at /dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/index.js:906:18
    at IncomingMessage.<anonymous> (/dev/shm/workspace/kibana/node_modules/supertest/node_modules/superagent/lib/node/parsers/json.js:19:7)
    at endReadableNT (_stream_readable.js:1327:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`kibanaUtils`	191	251	+60
`visualizations`	152	150	-2
total			+58

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`kibanaUtils`	123.2KB	123.2KB	+89.0B

Distributable file count

id	before	after	diff
`default`	47227	47987	+760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kibanaUtils`	150.4KB	173.0KB	+22.7KB
`visualizations`	169.1KB	163.8KB	-5.3KB
total			+17.4KB

History

💔 Build #94060 failed 5e67166
💔 Build #94037 failed 5a92ee7cfe394aa2ab323bc12e5c46ba6a72b85f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[Visualizations] Remove src/plugins/charts -> src/plugins/expressions…

5e67166

… cyclic dependencies

alexwizp force-pushed the charts<-->expressions branch from 5a92ee7 to 5e67166 Compare December 14, 2020 15:33

alexwizp mentioned this pull request Dec 14, 2020

Remove circular deps between KibanaApp team plugins #84750

Closed

5 tasks

Merge branch 'master' into charts<-->expressions

732e460

alexwizp closed this Dec 22, 2020

alexwizp deleted the charts<-->expressions branch January 16, 2021 15:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Visualizations] Remove src/plugins/charts -> src/plugins/expressions cyclic dependencies#85788

[Visualizations] Remove src/plugins/charts -> src/plugins/expressions cyclic dependencies#85788
alexwizp wants to merge 2 commits intoelastic:masterfrom
alexwizp:charts<-->expressions

alexwizp commented Dec 14, 2020

Uh oh!

alexwizp commented Dec 15, 2020

Uh oh!

kibanamachine commented Dec 15, 2020 •

edited

Loading

Standard Out

Stack Trace

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

alexwizp commented Dec 14, 2020

Summary

Checklist

For maintainers

Uh oh!

alexwizp commented Dec 15, 2020

Uh oh!

kibanamachine commented Dec 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Module Count

Async chunks

Distributable file count

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kibanamachine commented Dec 15, 2020 •

edited

Loading