Skip to content

[7.x] [Security Solution] Refactor Timeline Notes to use EuiCommentList (#85256)#85716

Merged
XavierM merged 1 commit intoelastic:7.xfrom
XavierM:backport/7.x/pr-85256
Dec 13, 2020
Merged

[7.x] [Security Solution] Refactor Timeline Notes to use EuiCommentList (#85256)#85716
XavierM merged 1 commit intoelastic:7.xfrom
XavierM:backport/7.x/pr-85256

Conversation

@XavierM
Copy link
Copy Markdown
Contributor

@XavierM XavierM commented Dec 13, 2020

Backports the following commits to 7.x:

…astic#85256)

* [Security Solution] Refactor Timeline Notes to use EuiCommentList

* notes

* fix types

* unit tests

* selector

* uncomment Pinned tab

* note event details

* cleanup

* cleanup

* transparent background

* don't display elastic as an owner when note is created

* review + bugs fixed found

Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>
@XavierM XavierM added the backport This PR is a backport of another PR label Dec 13, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2124 2119 -5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.3MB 8.3MB +2.8KB

Distributable file count

id before after diff
default 47411 48171 +760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit a2771a3 into elastic:7.x Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants