Skip to content

[7.x] fix layout on safari (#85442)#85581

Merged
angorayc merged 1 commit intoelastic:7.xfrom
angorayc:backport/7.x/pr-85442
Dec 10, 2020
Merged

[7.x] fix layout on safari (#85442)#85581
angorayc merged 1 commit intoelastic:7.xfrom
angorayc:backport/7.x/pr-85442

Conversation

@angorayc
Copy link
Copy Markdown
Contributor

@angorayc angorayc commented Dec 10, 2020

Backports the following commits to 7.x:

@angorayc @kibanamachine
fix layout on safari (elastic#85442)
777a210 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@angorayc angorayc added the backport This PR is a backport of another PR label Dec 10, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 10, 2020

💛 Build succeeded, but was flaky

Test Failures

Creates and activates a new custom rule with override option.Detection rules, override Creates and activates a new custom rule with override option

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 12 times on tracked branches: https://github.com/elastic/kibana/issues/84020

AssertionError: Timed out retrying: expected '<button.euiButtonEmpty.euiButtonEmpty--text.euiFilterButton>' to have text 'Custom rules (1)', but the text was 'Custom rules (3)'
    at Context.eval (http://localhost:6111/__cypress/tests?p=cypress/integration/alerts_detection_rules_override.spec.ts:20344:59)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.3MB 8.2MB -126.0B

Distributable file count

id before after diff
default 47340 48100 +760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc merged commit e23e1ad into elastic:7.x Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@angorayc @kibanamachine