Skip to content

[7.x] [SECURITY SOLUTION] Bundles _source -> Fields + able to sort on multiple fields in Timeline (#83761)#85505

Merged
XavierM merged 2 commits intoelastic:7.xfrom
XavierM:backport/7.x/pr-83761
Dec 10, 2020
Merged

[7.x] [SECURITY SOLUTION] Bundles _source -> Fields + able to sort on multiple fields in Timeline (#83761)#85505
XavierM merged 2 commits intoelastic:7.xfrom
XavierM:backport/7.x/pr-83761

Conversation

@XavierM
Copy link
Copy Markdown
Contributor

@XavierM XavierM commented Dec 10, 2020

Backports the following commits to 7.x:

@XavierM @patrykkopycinski
[SECURITY SOLUTION] Bundles _source -> Fields + able to sort on multi…
c90e995 
…ple fields in Timeline (elastic#83761)

* replace _source with fields

* wip

* unit test

* regroup sorting and number together

* fix bugs from review

* mistake

* Update x-pack/plugins/security_solution/public/timelines/components/timeline/body/column_headers/index.tsx

Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>

* fix snapshot

* review + fix topN and filter from detail view

* fix tests

* fix test

Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
@XavierM XavierM added the backport This PR is a backport of another PR label Dec 10, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 10, 2020

💛 Build succeeded, but was flaky

Test Failures

Creates and activates a new custom rule with override option.Detection rules, override Creates and activates a new custom rule with override option

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 11 times on tracked branches: https://github.com/elastic/kibana/issues/84020

AssertionError: Timed out retrying: expected '<button.euiButtonEmpty.euiButtonEmpty--text.euiFilterButton>' to have text 'Custom rules (1)', but the text was 'Custom rules (3)'
    at Context.eval (http://localhost:6111/__cypress/tests?p=cypress/integration/alerts_detection_rules_override.spec.ts:20344:59)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2116 2117 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.2MB 8.3MB +4.7KB

Distributable file count

id before after diff
default 47320 48080 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 0968676 into elastic:7.x Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XavierM @kibanamachine @patrykkopycinski