Skip to content

[7.10] [Fleet] Handler api key creation errors when Fleet Admin is invalid (#84576)#84691

Merged
nchaulet merged 7 commits intoelastic:7.10from
nchaulet:backport/7.10/pr-84576
Dec 4, 2020
Merged

[7.10] [Fleet] Handler api key creation errors when Fleet Admin is invalid (#84576)#84691
nchaulet merged 7 commits intoelastic:7.10from
nchaulet:backport/7.10/pr-84576

Conversation

@nchaulet
Copy link
Copy Markdown
Member

@nchaulet nchaulet commented Dec 1, 2020

Backports the following commits to 7.10:

@nchaulet
[Fleet] Handler api key creation errors when Fleet Admin is invalid (e…
d9ee2eb 
…lastic#84576)

# Conflicts:
#	x-pack/plugins/fleet/public/applications/fleet/sections/agents/enrollment_token_list_page/components/new_enrollment_key_flyout.tsx
#	x-pack/test/fleet_api_integration/apis/enrollment_api_keys/crud.ts
@nchaulet nchaulet added the backport This PR is a backport of another PR label Dec 1, 2020
@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Dec 2, 2020

@elasticmachine merge upstream

@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Dec 2, 2020

@elasticmachine merge upstream

@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Dec 3, 2020

@elasticmachine merge upstream

@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Dec 3, 2020

@spalger I would love some help here to understand why CI is failing :)

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Dec 3, 2020

@nchaulet it looks like the Jest Unit tests are timing out, they get stuck at some point and don't complete... https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/91730/execution/node/341/log/?consoleFull

(figured that out by looking for orbs on https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/91730/flowGraphTable/ that aren't blue)

Are you able to run the jest tests locally without issue? I suspect that a change in this PR is causing a test to behave strangely and breaking jest... maybe a mock gone awry?

@nchaulet
Copy link
Copy Markdown
Member Author

nchaulet commented Dec 3, 2020

Thanks a unit test was effectively never finishing, it should be fixed (it's now working locally) 🤞

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 3, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestManager 1.2MB 1.2MB +60.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nchaulet nchaulet merged commit 6059568 into elastic:7.10 Dec 4, 2020
@nchaulet nchaulet deleted the backport/7.10/pr-84576 branch December 4, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nchaulet @spalger @kibanamachine