Skip to content

[7.x] TSVB should use "histogram:maxBars" and "histogram:barTarget" settings for auto instead of a default 100 buckets (#83628)#84250

Merged
alexwizp merged 1 commit intoelastic:7.xfrom
alexwizp:backport/7.x/pr-83628
Nov 25, 2020
Merged

[7.x] TSVB should use "histogram:maxBars" and "histogram:barTarget" settings for auto instead of a default 100 buckets (#83628)#84250
alexwizp merged 1 commit intoelastic:7.xfrom
alexwizp:backport/7.x/pr-83628

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

…s for auto instead of a default 100 buckets (elastic#83628)

* TSVB needs a "tsvb:max_buckets" target setting for auto instead of a default 120 buckets

Closes: elastic#54012

* remove calculate_auto

* max bars -> Level of detail

* rename allowLevelofDetail

* fix PR comment

* Update constants.ts

* Update src/plugins/vis_type_timeseries/public/application/components/index_pattern.js

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* create LEVEL_OF_DETAIL_MIN_BUCKETS constant

* calcAutoIntervalLessThan -> search.aggs.calcAutoIntervalLessThan

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
# Conflicts:
#	src/plugins/data/server/server.api.md
@alexwizp alexwizp added the backport This PR is a backport of another PR label Nov 24, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 1.8MB 1.8MB +3.6KB

Distributable file count

id before after diff
default 43392 43391 -1
oss 22876 22875 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 976.9KB 978.3KB +1.4KB
visTypeTimeseries 137.2KB 137.9KB +698.0B
total +2.0KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit 8e0b99a into elastic:7.x Nov 25, 2020
@alexwizp alexwizp deleted the backport/7.x/pr-83628 branch January 16, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants