Skip to content

[7.x] [Search] Search batching using bfetch (#83418)#84018

Merged
lizozom merged 1 commit intoelastic:7.xfrom
lizozom:backport/7.x/pr-83418
Nov 22, 2020
Merged

[7.x] [Search] Search batching using bfetch (#83418)#84018
lizozom merged 1 commit intoelastic:7.xfrom
lizozom:backport/7.x/pr-83418

Conversation

@lizozom
Copy link
Copy Markdown
Contributor

@lizozom lizozom commented Nov 22, 2020

Backports the following commits to 7.x:

* Use bfetch for search (no abort behavior)

* fix merge

* Handle request abortion + unit tests

* fix jest

* shim totals in oss

* proper formatting for errors

* jest, types and docs

* Fix doc

* Remove old search code and rename UI Setting

* jest mocks

* jest

* Solve unhanled error

* Use AbortSignal

* ts

* code review - use abort controller instead of observable

* Revert "Remove old search code and rename UI Setting"

This reverts commit 17de9fa.

* Remove old search code and rename UI Setting

* revert search route

* fix event unsubscribe

* code review 2

* revert filter

* simplify batch done logic

* code review

* filter items in the beginning

* jest

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@lizozom lizozom added the backport This PR is a backport of another PR label Nov 22, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
bfetch 20 21 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
bfetch 18.6KB 19.9KB +1.2KB
data 976.6KB 976.2KB -417.0B
dataEnhanced 36.3KB 36.3KB +28.0B
total +862.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lizozom lizozom merged commit 1385323 into elastic:7.x Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants