[7.x] [ILM] Policy form should not throw away data (#83077)#83893
Merged
jloleysens merged 2 commits intoelastic:7.xfrom Nov 23, 2020
Merged
[7.x] [ILM] Policy form should not throw away data (#83077)#83893jloleysens merged 2 commits intoelastic:7.xfrom
jloleysens merged 2 commits intoelastic:7.xfrom
Conversation
* fix ilm policy deserialization * reorder expected jest object to match actual * fix removal of wait for snapshot if it is not on the form * add client integration test for policy serialization of unknown fields * save on a few chars * added unit test for deserializer and serializer * Implement feedback - move serializer function around a little bit - move serialize migrate and allocate function out of serializer file * Updated serialization unit test coverage - removed the "forcemergeEnabled" meta field that was not being used - added test cases for deleting of values from policies * fixed minor issue in how serialization tests are being set up Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: