[Workplace Search] Migrate AddSource tree#83799
Merged
scottybollinger merged 11 commits intoelastic:masterfrom Nov 19, 2020
Merged
[Workplace Search] Migrate AddSource tree#83799scottybollinger merged 11 commits intoelastic:masterfrom
scottybollinger merged 11 commits intoelastic:masterfrom
Conversation
Changes for pre-commit hooks were: - Linting - Lodash imports - changed enum names in add_source because there were collistions with component names. So SaveConfig becomes SaveConfigStep because there is a component by the same name - replaced apostrophe’s with ‘'’ per lint rule Finally, the linter didn’t like this expression: asOauthRedirect ? onOauthFormSubmit() : onCredentialsFormSubmit(); … so I changed it to: const onSubmit = hasOauthRedirect ? onOauthFormSubmit : onCredentialsFormSubmit; onSubmit();
Sidebar copy and breadcrumbs will be recreated at the top level in a separate PR
In Kibana, breadcrumbs will be at the top-level and not in the view Also, we have no sidebar with contextual copy. The Figma designs call for this copy to be above the main content. For now I am placing this in the existing ViewContentHeader component. This will be slightly broken because of the structure of ViewContentHeader but that is expected for now since it cannot be rendered in the browser yet to fix
This is a placeholder until elastic#83750 lands
yakhinvadim
reviewed
Nov 19, 2020
Contributor
yakhinvadim
left a comment
There was a problem hiding this comment.
That was super easy to review, thank you!
2 small questions:
...ions/workplace_search/views/content_sources/components/add_source/available_sources_list.tsx
Show resolved
Hide resolved
...ons/workplace_search/views/content_sources/components/add_source/configured_sources_list.tsx
Outdated
Show resolved
Hide resolved
Looks like the value is always passed
yakhinvadim
approved these changes
Nov 19, 2020
Contributor
yakhinvadim
left a comment
There was a problem hiding this comment.
Amazing work, Scotty!
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the ContentSources AddSource tree from
ent-search.As a part of the migration to Kibana, we are removing the sidebar. Am using ViewContentHeader for now.