Closed
Conversation
smith
commented
Nov 19, 2020
| const theme = useTheme(); | ||
| const { serviceName } = useParams<{ serviceName?: string }>(); | ||
| const { urlParams, uiFilters } = useUrlParams(); | ||
| const transactionType = 'request'; |
Contributor
Author
There was a problem hiding this comment.
Hard-coding this as "request" until changes from #83587 are merged.
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
Contributor
|
Can you add a screenshot to the PR description please? 🙏 |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
merge conflict between base and head |
x-pack/plugins/apm/public/components/app/Main/route_config/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/service_overview/service_overview_throughput_chart.tsx
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/service_overview/service_overview_throughput_chart.tsx
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/service_overview/service_overview_throughput_chart.tsx
Show resolved
Hide resolved
cauemarcondes
approved these changes
Nov 26, 2020
Contributor
cauemarcondes
left a comment
There was a problem hiding this comment.
LGTM, just added some small comments
Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Contributor
💔 Build Failed
Failed CI StepsMetrics [docs]Module Count
Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
Contributor
|
Replaced by #84439 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the throughput (traffic) chart to the overview page.