Skip to content

[Workplace Search] Migrate sourceData from ent-search#83459

Merged
scottybollinger merged 10 commits intoelastic:masterfrom
scottybollinger:scottybollinger/source_data
Nov 16, 2020
Merged

[Workplace Search] Migrate sourceData from ent-search#83459
scottybollinger merged 10 commits intoelastic:masterfrom
scottybollinger:scottybollinger/source_data

Conversation

@scottybollinger
Copy link
Copy Markdown
Contributor

@scottybollinger scottybollinger commented Nov 16, 2020

Summary

This PR migrates sourceData.tsx from ent-search. No changes other than linting were made and i18n strings converted.

The 2 routes for the Salesforce Sandbox were also added as a part of this PR.

Salesforce Sandbox routes had been added since the routes were migrated.
This is a direct port from `ent-search` with no changes other than linting.
@scottybollinger scottybollinger added Feature:Plugins v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 16, 2020
@scottybollinger scottybollinger requested review from a team and yakhinvadim November 16, 2020 18:11
Copy link
Copy Markdown
Contributor

@yakhinvadim yakhinvadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omg, it's happening! 🎉

Shared items were extracted to constants. Others were done inline
Copy link
Copy Markdown
Contributor

@yakhinvadim yakhinvadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 683.6KB 691.6KB +8.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger scottybollinger merged commit 2286c50 into elastic:master Nov 16, 2020
@scottybollinger scottybollinger deleted the scottybollinger/source_data branch November 16, 2020 21:53
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 18, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 83459 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 83459 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 83459 or prevent reminders by adding the backport:skip label.

@scottybollinger scottybollinger added the backport:skip This PR does not require backporting label Nov 20, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants