[Workplace Search] Migrate sourceData from ent-search#83459
Merged
scottybollinger merged 10 commits intoelastic:masterfrom Nov 16, 2020
Merged
[Workplace Search] Migrate sourceData from ent-search#83459scottybollinger merged 10 commits intoelastic:masterfrom
scottybollinger merged 10 commits intoelastic:masterfrom
Conversation
Salesforce Sandbox routes had been added since the routes were migrated.
This is a direct port from `ent-search` with no changes other than linting.
yakhinvadim
approved these changes
Nov 16, 2020
Contributor
yakhinvadim
left a comment
There was a problem hiding this comment.
Omg, it's happening! 🎉
Shared items were extracted to constants. Others were done inline
scottybollinger
commented
Nov 16, 2020
...enterprise_search/public/applications/workplace_search/views/content_sources/source_data.tsx
Outdated
Show resolved
Hide resolved
scottybollinger
commented
Nov 16, 2020
...enterprise_search/public/applications/workplace_search/views/content_sources/source_data.tsx
Outdated
Show resolved
Hide resolved
yakhinvadim
suggested changes
Nov 16, 2020
x-pack/plugins/enterprise_search/public/applications/workplace_search/constants.ts
Outdated
Show resolved
Hide resolved
...enterprise_search/public/applications/workplace_search/views/content_sources/source_data.tsx
Outdated
Show resolved
Hide resolved
...enterprise_search/public/applications/workplace_search/views/content_sources/source_data.tsx
Outdated
Show resolved
Hide resolved
...enterprise_search/public/applications/workplace_search/views/content_sources/source_data.tsx
Outdated
Show resolved
Hide resolved
scottybollinger
commented
Nov 16, 2020
...enterprise_search/public/applications/workplace_search/views/content_sources/source_data.tsx
Outdated
Show resolved
Hide resolved
yakhinvadim
approved these changes
Nov 16, 2020
x-pack/plugins/enterprise_search/public/applications/workplace_search/routes.ts
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
2 similar comments
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates sourceData.tsx from ent-search. No changes other than linting were made and i18n strings converted.
The 2 routes for the Salesforce Sandbox were also added as a part of this PR.