Skip to content

[7.10] [SecuritySolution] override timerange for prebuilt templates (#82468)#83454

Merged
angorayc merged 3 commits intoelastic:7.10from
angorayc:backport/7.10/pr-82468
Nov 17, 2020
Merged

[7.10] [SecuritySolution] override timerange for prebuilt templates (#82468)#83454
angorayc merged 3 commits intoelastic:7.10from
angorayc:backport/7.10/pr-82468

Conversation

@angorayc
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.10:

…#82468)

* override timerange for prebuilt templates

* add unit test

* add unit tests

* make sure it is template

* check timelineType

* overwrite prebuilt template's timerange

* update mock path

* override with relative timerange

* Update x-pack/plugins/security_solution/public/timelines/components/open_timeline/helpers.ts

Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>

* review

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Patryk Kopyciński <contact@patrykkopycinski.com>
@angorayc angorayc added the backport This PR is a backport of another PR label Nov 16, 2020
@angorayc
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@oatkiller
Copy link
Copy Markdown
Contributor

I think we should increase the 7.10 limit by a small amount with this PR. In master we have already implemented significant improvements and we aren't hitting limits there.

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 10.5MB 10.5MB +2.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 608.0KB 608.6KB +652.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc merged commit 8e6d31f into elastic:7.10 Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR v7.10.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants