Skip to content

[7.x] [Actions] Removing placeholders and updating validation messages on connector forms (#82734)#83336

Merged
ymao1 merged 1 commit intoelastic:7.xfrom
ymao1:backport/7.x/pr-82734
Nov 12, 2020
Merged

[7.x] [Actions] Removing placeholders and updating validation messages on connector forms (#82734)#83336
ymao1 merged 1 commit intoelastic:7.xfrom
ymao1:backport/7.x/pr-82734

Conversation

@ymao1
Copy link
Copy Markdown
Contributor

@ymao1 ymao1 commented Nov 12, 2020

Backports the following commits to 7.x:

…onnector forms (elastic#82734)

* Removing placeholders. Updating validation messages

* Splitting out url and protocol validation

* Adding url validation for slack webhook urls

* Fixing test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@ymao1 ymao1 added the backport This PR is a backport of another PR label Nov 12, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.5MB 1.5MB -207.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 133.3KB 135.2KB +1.9KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ymao1 ymao1 merged commit d449d53 into elastic:7.x Nov 12, 2020
@ymao1 ymao1 deleted the backport/7.x/pr-82734 branch February 4, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants