Skip to content

[7.x] [ML] Persisted URL state for the "Anomaly detection jobs" page (#83149)#83285

Merged
darnautov merged 1 commit intoelastic:7.xfrom
darnautov:backport/7.x/pr-83149
Nov 12, 2020
Merged

[7.x] [ML] Persisted URL state for the "Anomaly detection jobs" page (#83149)#83285
darnautov merged 1 commit intoelastic:7.xfrom
darnautov:backport/7.x/pr-83149

Conversation

@darnautov
Copy link
Copy Markdown
Contributor

@darnautov darnautov commented Nov 12, 2020

Backports the following commits to 7.x:

@darnautov
[ML] Persisted URL state for the "Anomaly detection jobs" page (elast…
ad2c06c 
…ic#83149)

* [ML] table config in the URL state

* [ML] fix job list on the management page

* [ML] store query filter in the URL

* [ML] fix context for the management page

* [ML] update module_list_card.tsx in Logs UI

* [ML] fix unit tests

* [ML] fix unit tests

* [ML] fix unit tests

* [ML] move utils functions

* [ML] url generator to support both job and group ids
@darnautov darnautov added the backport This PR is a backport of another PR label Nov 12, 2020
@darnautov darnautov self-assigned this Nov 12, 2020
@darnautov darnautov added the :ml label Nov 12, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 12, 2020

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 12, 2020

💛 Build succeeded, but was flaky

Test Failures

Creates a timeline template.Timeline Templates Creates a timeline template

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 4 times on tracked branches: https://github.com/elastic/kibana/issues/79967

CypressError: `cy.wait()` could not find a registered alias for: `@timeline`.
You have not aliased anything yet.
    at aliasNotFoundFor (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:150300:22)
    at $Cy.getAlias (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:150263:7)
    at waitForXhr (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:159952:27)
    at http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:160039:14
    at tryCatcher (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:10325:23)
    at MappingPromiseArray._promiseFulfilled (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:7445:38)
    at MappingPromiseArray.PromiseArray._iterate (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:8647:31)
    at MappingPromiseArray.init (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:8611:10)
    at MappingPromiseArray._asyncInit (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:7414:10)
    at _drainQueueStep (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:5036:12)
    at _drainQueue (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:5025:9)
    at Async.../../node_modules/bluebird/js/release/async.js.Async._drainQueues (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:5041:5)
    at Async.drainQueues (http://elastic:changeme@localhost:6111/__cypress/runner/cypress_runner.js:4911:14)
From Your Spec Code:
    at Context.eval (http://localhost:6111/__cypress/tests?p=cypress/integration/timeline_template_creation.spec.ts:13497:35)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.5MB 2.5MB +3.9KB
ml 6.7MB 4.5MB -2.2MB
total -2.2MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 174.0KB 174.3KB +236.0B
ml 63.5KB 66.0KB +2.5KB
total +2.7KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@darnautov darnautov merged commit 8ce70da into elastic:7.x Nov 12, 2020
@darnautov darnautov deleted the backport/7.x/pr-83149 branch November 12, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@darnautov darnautov

Labels

backport This PR is a backport of another PR :ml

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@darnautov @elasticmachine @kibanamachine