Skip to content

[7.x] [App Search] Misc naming tech debt (#82770)#83019

Merged
cee-chen merged 1 commit intoelastic:7.xfrom
cee-chen:backport/7.x/pr-82770
Nov 10, 2020
Merged

[7.x] [App Search] Misc naming tech debt (#82770)#83019
cee-chen merged 1 commit intoelastic:7.xfrom
cee-chen:backport/7.x/pr-82770

Conversation

@cee-chen
Copy link
Copy Markdown
Contributor

@cee-chen cee-chen commented Nov 9, 2020

Backports the following commits to 7.x:

* Rename `engine_overview` folder to `engines`

- To better match ent-search folder structure
- Also rename/clarify pluralization of "Engines" where possible, to distinguish between individual Engine Overview pages

* DRY out Engines and Meta Engines titles

* DRY out Credentials title

* DRY out Settings title

* DRY out Role Mappings title

* Update localization keys to match changes

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@cee-chen cee-chen added the backport This PR is a backport of another PR label Nov 9, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 449 453 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 666.7KB 666.2KB -492.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen merged commit 04cfe46 into elastic:7.x Nov 10, 2020
@cee-chen cee-chen deleted the backport/7.x/pr-82770 branch November 10, 2020 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants