[7.x] Move single use function in line (#82885)#82997
Merged
jfsiii merged 1 commit intoelastic:7.xfrom Nov 11, 2020
jfsiii:backport/7.x/pr-82885
Merged
[7.x] Move single use function in line (#82885)#82997jfsiii merged 1 commit intoelastic:7.xfrom jfsiii:backport/7.x/pr-82885
jfsiii merged 1 commit intoelastic:7.xfrom
jfsiii:backport/7.x/pr-82885
Conversation
## Summary
* Function rename to follow existing get/fetch convention
```diff
- export async function loadRegistryPackage(
+ export async function getRegistryPackage(
```
* Moved `unpackRegistryPackageToCache` into `getRegistryPackage`
* In my opinion, those three/four statements are more clear than the previous name
* It isn't used anywhere else
Contributor
💛 Build succeeded, but was flaky
Test FailuresChrome UI Functional Tests.test/functional/apps/dashboard/url_field_formatter·ts.dashboard app using current data Changing field formatter to Url applied on dashboardStandard OutStack TraceMetrics [docs]
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: