Skip to content

[7.x] [Visualize] New visualization wizard (#79627)#82858

Merged
stratoula merged 1 commit intoelastic:7.xfrom
stratoula:backport/7.x/pr-79627
Nov 6, 2020
Merged

[7.x] [Visualize] New visualization wizard (#79627)#82858
stratoula merged 1 commit intoelastic:7.xfrom
stratoula:backport/7.x/pr-79627

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* [Visualizations] New vis wizard

* Update functional tests

* Create oss plugins for maps and lens and unregister alias function

* Add new plugins to .i18nrc.json

* Add readme and codeowners to the new plugins

* update docs

* fix tests

* fix types

* fixes

* Update development docs

* fix oss functional tests

* Fix jest and x-pack functional tests

* Fix functional test

* changes on the layout

* Cleanup and responsiveness

* cleanup unecessary code

* add common folder to the new OSS plugins

* remove unecessary translations

* Update limits.yml file

* Fix basic label

* Add experimental badge on controls vis

* Nice improvements

* fixes

* Improving styles

* Making modal go full height on smaller screens

* Fixing sass lint warning

* fix lint error

* fix internationalization error

* PR fixes

* PR changes

* Use useCallback where possible

* Remove translations that need to be translated again

* Lazy Load wizard modal

* Remove legacyMapVisualizationWarning

* Import the OSS plugins constants from the plugins

* Export constant from lensOss

* Change the new oss plugins from OSS to Oss

* Add a new line to the kibana.json files of the new plugins

* New nit fix

* Fix spaces

* Change the texts for the first step of the modal

* Fix test

* Fixes some of the PR comments

* Add onClick funtionality to the entire aggregation based card

* Cards description changes, introduce a copyFromRoot method to solve the problem of when disabling the x-pack plugic, to also disable the oss

* Create new FTR for testing the functionality of the wizard when both maps and lens apps are disabled

* fix eslint error

* Change groupTitles and descriptions

* Change input vis description

* Remove the copyFromRoot from the signature of the ConfigDeprecationFactory and export it from the main entrypoint

* Make the disabled cards badge clickable

* Changes from code review

* Fix functional tests failures

* Rename groupTitle to titleInWizard to be more specific

* Change vega vis note

* minor design changes

* fix problem with plugins list docs

* Retrieve maps and lens landing page from docs service and add tracking url param

* Fix funtional test for the new dashboard flow

* Fix logic in alias registry for removing the discardOnRegister alias

* no need to remove the alias entry from the discardOnRegister array

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: miukimiu <elizabet.oliveira@elastic.co>
# Conflicts:
#	.github/CODEOWNERS
#	docs/developer/plugin-list.asciidoc
#	packages/kbn-optimizer/limits.yml
#	x-pack/scripts/functional_tests.js
@stratoula stratoula added the backport This PR is a backport of another PR label Nov 6, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
lensOss - 7 +7
mapsOss - 7 +7
visualizations 134 153 +19
total +33

async chunk count

id before after diff
visualizations 0 1 +1

async chunks size

id before after diff
lens 1022.2KB 1022.2KB +1.0B
maps 2.8MB 2.8MB +3.0B
visualizations 0.0B 57.0KB +57.0KB
total +57.0KB

distributable file count

id before after diff
default 43087 43108 +21
oss 22726 22747 +21

page load bundle size

id before after diff
core 547.6KB 547.8KB +200.0B
inputControlVis 104.5KB 104.8KB +341.0B
lens 49.7KB 50.0KB +218.0B
lensOss - 4.5KB +4.5KB
maps 154.1KB 154.1KB -13.0B
mapsOss - 4.3KB +4.3KB
visTypeMarkdown 14.5KB 14.6KB +176.0B
visTypeTimeseries 132.9KB 132.9KB +51.0B
visTypeVega 57.4KB 57.7KB +328.0B
visTypeVislib 66.1KB 66.0KB -75.0B
visualizations 205.5KB 170.5KB -35.0KB
total -25.0KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 73d2de6 into elastic:7.x Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants