Skip to content

[7.10] [SECURITY SOLUTIONS] Keep context of timeline when switching tabs in security solutions (#82237)#82794

Merged
XavierM merged 3 commits intoelastic:7.10from
XavierM:backport/7.10/pr-82237
Nov 9, 2020
Merged

[7.10] [SECURITY SOLUTIONS] Keep context of timeline when switching tabs in security solutions (#82237)#82794
XavierM merged 3 commits intoelastic:7.10from
XavierM:backport/7.10/pr-82237

Conversation

@XavierM
Copy link
Copy Markdown
Contributor

@XavierM XavierM commented Nov 6, 2020

Backports the following commits to 7.10:

…security solutions (elastic#82237)

* try to keep timeline context when switching tabs

* fix popover

* simpler solution to keep timelien context between tabs

* fix timeline context with relative date

* allow update on the kql bar when opening new timeline

* keep detail view in context when savedObjectId of the timeline does not chnage

* remove redux solution and just KISS it

* add unit test for the popover

* add test on timeline context cache

* final commit -> to fix context of timeline between tabs

* keep timerange kind to absolute when refreshing

* fix bug today/thiw week to be absolute and not relative

* add unit test for absolute date for today and this week

* fix absolute today/this week on timeline

* fix refresh between page and timeline when link

* clean up

* remove nit

Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
@XavierM XavierM added the backport This PR is a backport of another PR label Nov 6, 2020
@patrykkopycinski
Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
securitySolution 2040 2039 -1

async chunks size

id before after diff
securitySolution 10.5MB 10.5MB -15.4KB

page load bundle size

id before after diff
securitySolution 604.0KB 608.0KB +4.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 04d397c into elastic:7.10 Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants