Skip to content

[7.10] [Time to Visualize] Embeddable Error Handling Without ReplacePanel (#82201)#82744

Merged
ThomThomson merged 2 commits intoelastic:7.10from
ThomThomson:backport/7.10/pr-82201
Nov 5, 2020
Merged

[7.10] [Time to Visualize] Embeddable Error Handling Without ReplacePanel (#82201)#82744
ThomThomson merged 2 commits intoelastic:7.10from
ThomThomson:backport/7.10/pr-82201

Conversation

@ThomThomson
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.10:

…lastic#82201)

Fixed embeddable error handling so that fatal errors are caught and displayed with an errorEmbeddable no matter when they occur.
# Conflicts:
#	docs/development/plugins/embeddable/public/kibana-plugin-plugins-embeddable-public.embeddable.md
#	docs/development/plugins/embeddable/public/kibana-plugin-plugins-embeddable-public.iembeddable.md
#	src/plugins/dashboard/public/application/actions/library_notification_action.tsx
#	src/plugins/embeddable/public/public.api.md
#	x-pack/plugins/lens/public/lens_attribute_service.ts
@ThomThomson ThomThomson added the backport This PR is a backport of another PR label Nov 5, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
dashboard 221.5KB 221.6KB +126.0B
lens 1.0MB 1.0MB +153.0B
total +279.0B

distributable file count

id before after diff
default 48478 48479 +1
oss 28827 28828 +1

page load bundle size

id before after diff
dashboard 350.8KB 351.3KB +510.0B
embeddable 222.4KB 222.9KB +526.0B
lens 79.8KB 79.8KB +51.0B
total +1.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit 5729a23 into elastic:7.10 Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants