[7.x] [Enterprise Search] Telemetry: refactor to Kea logic file (#81926)#82473
Merged
cee-chen merged 1 commit intoelastic:7.xfrom Nov 3, 2020
Merged
[7.x] [Enterprise Search] Telemetry: refactor to Kea logic file (#81926)#82473cee-chen merged 1 commit intoelastic:7.xfrom
cee-chen merged 1 commit intoelastic:7.xfrom
Conversation
) * Add new TelemetryLogic helpers - DRYs out need to import/pass http lib - adds product-specific helpers which DRYs out an extra line * Update all previous sendTelemetry fns to use new logic actions * Update unit tests for updated components - Create reusable mocks - Update overview_logic.ts to use new Kea mock helpers (required for recent_activity.test to pass) * Cleanup: Remove old sendTelemetry fn + update tests * [PR feedback] Correctly assert the async thrown error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: