Skip to content

[Mappings editor] Fix regressions in scaled_float and date_range types#81286

Merged
sebelga merged 3 commits intoelastic:7.10from
sebelga:fix/mappings-editor-regressions
Oct 21, 2020
Merged

[Mappings editor] Fix regressions in scaled_float and date_range types#81286
sebelga merged 3 commits intoelastic:7.10from
sebelga:fix/mappings-editor-regressions

Conversation

@sebelga
Copy link
Copy Markdown
Contributor

@sebelga sebelga commented Oct 21, 2020 •
edited
Loading

This PR a regression in the "scaled_float" and "date_range" field type in the mappings editor.

The fix was brought in master and 7.x in #80842.
I have created a separate PR (#81287) to bring the tests from this PR over to those branches.

Fixes #81160

@sebelga sebelga added bug Fixes for quality problems that affect the customer experience v7.10.0 Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// labels Oct 21, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 21, 2020

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@sebelga sebelga added the release_note:skip Skip the PR/issue when compiling release notes label Oct 21, 2020
@sebelga sebelga changed the title Fix/mappings editor regressions [Mappings editor] Fix regressions in scaled_float and date_range types Oct 21, 2020
@sebelga sebelga mentioned this pull request Oct 21, 2020
Merged
@sebelga sebelga requested a review from yuliacech October 21, 2020 10:00
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 21, 2020

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
indexManagement 632.3KB 632.9KB +559.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

yuliacech
yuliacech approved these changes Oct 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sebelga , changes LGTM, tested locally and all worked!

@sebelga
Copy link
Copy Markdown
Contributor Author

sebelga commented Oct 21, 2020

Thanks for the review @yuliacech !

@sebelga sebelga merged commit 21f6404 into elastic:7.10 Oct 21, 2020
@sebelga sebelga deleted the fix/mappings-editor-regressions branch October 21, 2020 12:37
@cjcenizal cjcenizal mentioned this pull request Dec 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yuliacech yuliacech yuliacech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebelga @elasticmachine @kibanamachine @yuliacech