[7.10] [Security Solution] [Detections] Disable edit button when user does not have actions privileges w/ rule + actions (#80220)#81056
Merged
dhurley14 merged 1 commit intoelastic:7.10from Oct 20, 2020
Conversation
…ot have actions privileges w/ rule + actions (elastic#80220) * disable edit button only when there is an action present on the rule to be edited, but the user attempting the edit does not have actions privileges * adds tooltip to explain why the edit rule button is disabled * prevent user from editing rules with actions on the all rules table * adds tooltip to appear on all rules table * updates tests for missing params and missing mock of useKibana * disable activate switch on all rules table and rule details page * remove as casting in favor of a boolean type guard to ensure actions.show capabilities are a boolean even though tye are typed as a boolean | Record * disable duplicate rule functionality for rules with actions * fix positioning of tooltips and add tooltip to rule duplicate button in overflow button * update tests * WIP - display bulk actions dropdown options as disabled + add tooltips describing why they are disabled * add eui tool tip as child of of each context menu item * PR feedback and utilize map of rule ids to rules to replace usage of array.finds * update snapshot * fix mocks * fix mocks * update wording with feedback from design team Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.10: