Skip to content

[7.10] Grid layout fixes (#80305)#80326

Merged
efreeti merged 1 commit intoelastic:7.10from
efreeti:backport/7.10/pr-80305
Oct 13, 2020
Merged

[7.10] Grid layout fixes (#80305)#80326
efreeti merged 1 commit intoelastic:7.10from
efreeti:backport/7.10/pr-80305

Conversation

@efreeti
Copy link
Copy Markdown
Contributor

@efreeti efreeti commented Oct 13, 2020

Backports the following commits to 7.10:

* fixes to make grid layout a bit more solid.

* Changed the spacing a bit more.

* Updated snapshot.
@efreeti efreeti added the backport This PR is a backport of another PR label Oct 13, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky


Test Failures

Creates a timeline.Timelines Creates a timeline

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 8 times on tracked branches: https://github.com/elastic/kibana/issues/79389

CypressError: Timed out retrying: `cy.click()` failed because this element is detached from the DOM.

`<mark class="euiMark">host.name</mark>`

Cypress requires elements be attached in the DOM to interact with them.

The previous command that ran was:

  > `cy.contains()`

This DOM element likely became detached somewhere between the previous and current command.

Common situations why this happens:
  - Your JS framework re-rendered asynchronously
  - Your app code reacted to an event firing and removed the element

You typically need to re-query for the element or add 'guards' which delay Cypress from running new commands.

https://on.cypress.io/element-has-detached-from-dom
    at $Cy.ensureAttached (http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:161202:24)
    at runAllChecks (http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:150095:12)
    at retryActionability (http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:150154:16)
    at tryCatcher (http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:10325:23)
    at Function.Promise.attempt.Promise.try (http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:7599:29)
    at tryFn (http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:165474:24)
    at whenStable (http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:165515:12)
    at http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:165033:16
    at tryCatcher (http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:10325:23)
    at Promise._settlePromiseFromHandler (http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:8260:31)
    at Promise._settlePromise (http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:8317:18)
    at Promise._settlePromise0 (http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:8362:10)
    at Promise._settlePromises (http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:8442:18)
    at Promise._fulfill (http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:8386:18)
    at http://elastic:changeme@localhost:6121/__cypress/runner/cypress_runner.js:10000:46
From Your Spec Code:
    at Object../cypress/tasks/timeline.ts.exports.addFilter (http://localhost:6121/__cypress/tests?p=cypress/integration/timeline_creation.spec.ts:14017:57)
    at Context.eval (http://localhost:6121/__cypress/tests?p=cypress/integration/timeline_creation.spec.ts:13492:20)

Metrics [docs]

async chunks size

id before after diff
securitySolution 10.5MB 10.5MB +1.7KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@efreeti efreeti merged commit 1329707 into elastic:7.10 Oct 13, 2020
@efreeti efreeti deleted the backport/7.10/pr-80305 branch October 13, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants