Skip to content

[7.10] [ILM] Cloud-specific changes for 7.10 (#79650)#80318

Merged
jloleysens merged 2 commits intoelastic:7.10from
jloleysens:backport/7.10/pr-79650
Oct 13, 2020
Merged

[7.10] [ILM] Cloud-specific changes for 7.10 (#79650)#80318
jloleysens merged 2 commits intoelastic:7.10from
jloleysens:backport/7.10/pr-79650

Conversation

@jloleysens
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.10:

* added cloud cold tier specific call out, probably wip

* added jest test

* rephrase copy

* Added logic for showing/hiding data tier allocation option

- Added server-side test for detecting legacy config
- Added client-side test for asserting on cloud data tier option
  is hidden

* added test for not-on-cloud case

* Refactored logic for rendering data allocation notices

Also updated a comment.

* paraphrashing of Adams copy recommendation

* Fix comment

* address pr feedback

* clarify slight hack comment

* complete refactor of new flag for tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/index_lifecycle_management/server/routes/api/nodes/register_list_route.ts
@jloleysens jloleysens added backport This PR is a backport of another PR v7.10.0 labels Oct 13, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
indexLifecycleManagement 206 208 +2

async chunks size

id before after diff
indexLifecycleManagement 233.3KB 235.3KB +2.1KB

distributable file count

id before after diff
default 48761 48762 +1

page load bundle size

id before after diff
indexLifecycleManagement 89.9KB 90.0KB +26.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit e80bb7f into elastic:7.10 Oct 13, 2020
@jloleysens jloleysens deleted the backport/7.10/pr-79650 branch October 13, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR v7.10.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants