Skip to content

[7.x] [Visualize Editor] Add cancel button when navigating from Dashboard (#77608)#79738

Merged
majagrubic merged 1 commit intoelastic:7.xfrom
majagrubic:backport/7.x/pr-77608
Oct 6, 2020
Merged

[7.x] [Visualize Editor] Add cancel button when navigating from Dashboard (#77608)#79738
majagrubic merged 1 commit intoelastic:7.xfrom
majagrubic:backport/7.x/pr-77608

Conversation

@majagrubic
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

…lastic#77608)

* Add cancel button in the visualize editor

* Fixing i18n namespace

* Always show cancel button

* Always show cancel button

* Adding a fucntional test

* Show confirm dialog only if there are unsaved changes

* Show confirm modal only if there are changes

* Add onAppLeave handler and ditch confirmModal

* Fix functional test

* Only use onAppLeave if coming from dashboard/canvas

* Add actions.default to onSave and onSaveAndReturn

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@majagrubic majagrubic added the backport This PR is a backport of another PR label Oct 6, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
dashboard 221.4KB 221.5KB +11.0B
visualize 271.8KB 274.1KB +2.3KB
total +2.4KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@majagrubic majagrubic merged commit 09d5d75 into elastic:7.x Oct 6, 2020
@majagrubic majagrubic deleted the backport/7.x/pr-77608 branch October 6, 2020 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants