Skip to content

[7.x] [Search]Add EQL search strategy (#78645)#79499

Merged
rylnd merged 1 commit intoelastic:7.xfrom
rylnd:backport/7.x/pr-78645
Oct 5, 2020
Merged

[7.x] [Search]Add EQL search strategy (#78645)#79499
rylnd merged 1 commit intoelastic:7.xfrom
rylnd:backport/7.x/pr-78645

Conversation

@rylnd
Copy link
Copy Markdown
Contributor

@rylnd rylnd commented Oct 5, 2020

Backports the following commits to 7.x:

* Add EQL search strategy

Since EQL is an x-pack feature, this strategy will live in the
x-pack plugin data_enhanced.

* Refactor our test setup to minimize shared state

* Ensures that the same variable is not used for both test setup and
  test assertions
* Ensures that mocks are reinstantiated on every test

* Use explicit top-level exports

* Move async search options to a helper function

* Move our workaround to a helper function

This was repeated in five places, time to consolidate.

* Commit documentation changes

We export a few new helper functions.

* Mark our internal methods as such

Updates documentation accordingly.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@rylnd rylnd added the backport This PR is a backport of another PR label Oct 5, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

distributable file count

id before after diff
default 47387 47389 +2
oss 28857 28858 +1

page load bundle size

id before after diff
dataEnhanced 34.3KB 34.4KB +30.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rylnd rylnd merged commit 4537931 into elastic:7.x Oct 5, 2020
@rylnd rylnd deleted the backport/7.x/pr-78645 branch October 5, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants