Skip to content

[7.x] [Security Solution][Exceptions] Add lowercase normalizer for case-insensitivity + deprecate _tags field (new OS field) (#77379)#79376

Merged
madirey merged 2 commits intoelastic:7.xfrom
madirey:backport/7.x/pr-77379
Oct 3, 2020
Merged

[7.x] [Security Solution][Exceptions] Add lowercase normalizer for case-insensitivity + deprecate _tags field (new OS field) (#77379)#79376
madirey merged 2 commits intoelastic:7.xfrom
madirey:backport/7.x/pr-77379

Conversation

@madirey
Copy link
Copy Markdown
Contributor

@madirey madirey commented Oct 2, 2020

Backports the following commits to 7.x:

…ensitivity + deprecate _tags field (new OS field) (elastic#77379)

* Finish adding .lower to exceptionable fields

* Add back migrations

* .lower -> .caseless

* Add separate field for os type

* updates

* Type updates

* Switch over to osTypes

* get rid of _tags

* Add tests for schema validation

* Remove remaining references to _tags

* Another round of test fixes

* DefaultArray tests

* More test fixes

* Fix remaining test failures

* types / tests

* more test updates

* lowercase os values

* Address feedback + fix test failure

* tests

* Fix integration test

* process.executable.path -> process.executable.caseless

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@madirey madirey added the backport This PR is a backport of another PR label Oct 2, 2020
@madirey
Copy link
Copy Markdown
Contributor Author

madirey commented Oct 3, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
securitySolution 1994 1995 +1

async chunks size

id before after diff
securitySolution 10.3MB 10.3MB -1.3KB

distributable file count

id before after diff
default 47175 47177 +2

page load bundle size

id before after diff
lists 164.1KB 164.7KB +658.0B
securitySolution 585.5KB 586.4KB +996.0B
total +1.6KB

Saved Objects .kibana field count

id before after diff
exception-list 38 39 +1
exception-list-agnostic 38 39 +1
total +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@madirey madirey merged commit 3b60e12 into elastic:7.x Oct 3, 2020
@madirey madirey deleted the backport/7.x/pr-77379 branch October 3, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants