[backport] PR #7781 to 4.x - Implement template notifications#7916
Merged
[backport] PR #7781 to 4.x - Implement template notifications#7916
Conversation
6114c3f to
5414b21
Compare
5414b21 to
aace5fd
Compare
Member
|
@w33ble assigning this to you for a first look. This was a PITA to back port because notifier.js in 4.x doesn't have some abilities that were available when we worked on it in master:
I cherry-picked in most of the commits from #7781, except for the cleanup work where all the notifier types can take a config object, and the work where you made all the messages go through markdown. |
Contributor
Member
Contributor
Member
|
@w33ble does this LGTY? |
Contributor
|
@tsullivan still waiting on the "0 means don't use a timeout" commit here, aren't we? |
Member
|
@w33ble whoops I pushed to my fork but forgot this needs to be on the upstream repo |
Contributor
|
Now it's a winner! 🏆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #7781
Commit 1:
[Notifier] Added a custom notify function which allows complete control over notifications
Commit 2:
custom notifications: use
textas property for action button labelCommit 3:
remove distinction between content and markdown
just run all content through the markdown parser, and add margin to
alight text correctly
Commit 4:
fix timeout starting at 0 bug
Commit 5:
allow 0 to be used to disable timeout
Commit 6:
allow property overrides on helper methods
Commit 7:
make custom notify api closer to other helper apis
Commit 8:
update custom notification tests
Commit 9:
punch up the tests
check value types, more tests with less concerns, clean up notifications after each test
Commit 10:
fix issue with custom notification handling
Commit 11:
update the docblock
Commit 12:
Custom notification: throw error if config object is invalid
Commit 13:
Notifier Config: move overridableOptions to higher level
Commit 14:
switch order of negative/postive condition blocks
Commit 15:
remove unecessary ng-if
Commit 16:
remove limit of number of actions
Commit 17:
custom notifier dynamic lifetime based on type
Commit 18:
test cleanup per feedback
Commit 19:
allow passing of
type: ‘error’Commit 20:
add tests for latest enhancements