Skip to content

Expressions timings in the browser console#78885

Closed
wylieconlon wants to merge 2 commits intoelastic:mainfrom
wylieconlon:expression-debug-console
Closed

Expressions timings in the browser console#78885
wylieconlon wants to merge 2 commits intoelastic:mainfrom
wylieconlon:expression-debug-console

Conversation

@wylieconlon
Copy link
Copy Markdown
Contributor

@wylieconlon wylieconlon commented Sep 29, 2020

This is a PR that lets you see how many milliseconds each expression function takes, for visualize, lens, and canvas. For example:

Screen Shot 2020-09-29 at 6 40 04 PM

@wylieconlon wylieconlon added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Sep 29, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 29, 2020 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

Jest Tests.src/plugins/expressions/common/execution.Execution debug mode when functions succeed stores output of each function

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toEqual(expected) // deep equality

Expected: {"type": "num", "value": 0}
Received: undefined
    at Object.test (/dev/shm/workspace/parallel/5/kibana/src/plugins/expressions/common/execution/execution.test.ts:546:40)
Jest Tests.src/plugins/expressions/common/execution.Execution debug mode when functions succeed stores resolved arguments of a function

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toEqual(expected) // deep equality

Expected: {"val": 5}
Received: undefined
    at Object.test (/dev/shm/workspace/parallel/5/kibana/src/plugins/expressions/common/execution/execution.test.ts:571:38)
Jest Tests.src/plugins/expressions/common/execution.Execution debug mode when functions succeed store debug information about sub-expressions

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: undefined
    at Object.test (/dev/shm/workspace/parallel/5/kibana/src/plugins/expressions/common/execution/execution.test.ts:601:40)

Metrics [docs]

async chunks size

id value diff baseline
canvas 1.4MB +959.0B 1.4MB
lens 995.6KB +11.0B 995.6KB
total +970.0B

page load bundle size

id value diff baseline
expressions 205.2KB +1.0KB 204.2KB
lens 139.6KB +11.0B 139.6KB
visualizations 272.7KB +22.0B 272.7KB
total +1.0KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar
Copy link
Copy Markdown
Contributor

ppisljar commented Sep 30, 2020

how is this different from passing debug parameter to createExecution ?

  • not logging anything else but execution times ... that seems useful, but could be made configurable on the original createExecution debug parameter

is there something i am missing ?

@wylieconlon
Copy link
Copy Markdown
Contributor Author

wylieconlon commented Sep 30, 2020

@ppisljar This PR is the first step towards a "debug timing collector", there's a separate PR which lets us enable debug mode from client apps like Lens and Canvas. This is a separate chunk of work that could let us track and report on timing in an automated way.

@wylieconlon wylieconlon mentioned this pull request Sep 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clintandrewhall clintandrewhall Awaiting requested review from clintandrewhall

@streamich streamich Awaiting requested review from streamich

@ppisljar ppisljar Awaiting requested review from ppisljar

Assignees

No one assigned

Labels

Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wylieconlon @kibanamachine @ppisljar