Skip to content

[7.x] Adding comment about importing lodash library (#78156)#78667

Merged
smith merged 3 commits intoelastic:7.xfrom
brittanyjoiner15:backport/7.x/pr-78156
Oct 1, 2020
Merged

[7.x] Adding comment about importing lodash library (#78156)#78667
smith merged 3 commits intoelastic:7.xfrom
brittanyjoiner15:backport/7.x/pr-78156

Conversation

@brittanyjoiner15
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* added comment about importing lodash library

* fixed space with prefer

* cleaned up extra space and removed comments for lodash/fp

* took out the comment in server files

* Remove newlines

Co-authored-by: Nathan L Smith <smith@nlsmith.com>
@brittanyjoiner15
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

merge conflict between base and head

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
infra 1200 1133 -67

async chunks size

id before after diff
infra 4.2MB 4.3MB +38.0KB

page load bundle size

id before after diff
infra 137.8KB 137.7KB -25.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit ca42caa into elastic:7.x Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants